From: Chris Mason <mason@suse.com>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: deadlocks caused by ext3/reiser dirty_inode calls during do_mmap_pgoff
Date: Tue, 22 Jun 2004 16:41:55 -0400 [thread overview]
Message-ID: <1087936915.1512.284.camel@watt.suse.com> (raw)
In-Reply-To: <20040622120540.1bc8b6e3.akpm@osdl.org>
On Tue, 2004-06-22 at 15:05, Andrew Morton wrote:
> Chris Mason <mason@suse.com> wrote:
> > Oh, just realized this will break our data=ordered setup. prepare_write
> > is going to do things like allocating blocks in the file etc etc. If we
> > close the transaction via commit_write(0 size) and crash, we'll leak.
>
> OK, then just zero the pagecache page between `from' and `to' and call
> ->commit_write() with unmodified `from' and `to'?
>
> > We might need to do prefault + pin on the user pages.
>
> That's always been the correct way to fix these problems, but it involves a
> pagetable walk, which requires page_table_lock. Not a popular thing to be
> doing on the write() fastpath.
Fair enough, zeroing between from and to should do it.
-chris
next prev parent reply other threads:[~2004-06-22 20:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-21 16:59 Chris Mason
2004-06-22 0:13 ` Andrew Morton
2004-06-22 14:13 ` Chris Mason
2004-06-22 18:57 ` Andrew Morton
2004-06-22 20:32 ` Chris Mason
2004-06-22 14:43 ` Chris Mason
2004-06-22 19:05 ` Andrew Morton
2004-06-22 20:41 ` Chris Mason [this message]
2004-06-25 17:59 ` Chris Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1087936915.1512.284.camel@watt.suse.com \
--to=mason@suse.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome