From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Tom Rini <trini@kernel.crashing.org>
Cc: Andrew Morton <akpm@osdl.org>, Linus Torvalds <torvalds@osdl.org>,
Paul Mackerras <paulus@samba.org>,
Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ppc32: Cleanups & warning fixes of traps.c
Date: Tue, 22 Jun 2004 17:54:37 -0500 [thread overview]
Message-ID: <1087944876.1854.127.camel@gaston> (raw)
In-Reply-To: <20040622223453.GB9342@smtp.west.cox.net>
On Tue, 2004-06-22 at 17:34, Tom Rini wrote:
> On Tue, Jun 22, 2004 at 02:07:32PM -0500, Benjamin Herrenschmidt wrote:
>
> > Hi !
> >
> > This patch cleans up arch/ppc/kernel/traps.c and vecemu.c to use the same
> > formatting style for all functions,
>
> Isn't that undoing what Lindent does? Which is at least possibly why
> it's done that way now..
I don't know if that has anything to do with lindent. I used to format
that way myself but changed my mind, and paulus seemed to do both, but I
remember a recent discussion where Linus clearly explained his
preference having the return type on the same line as the function name.
It's also more handy with grep.
Ben.
prev parent reply other threads:[~2004-06-22 23:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-22 19:07 Benjamin Herrenschmidt
2004-06-22 22:34 ` Tom Rini
2004-06-22 22:54 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1087944876.1854.127.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@samba.org \
--cc=torvalds@osdl.org \
--cc=trini@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®