mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: john stultz <johnstul@us.ibm.com>
To: "Maciej W. Rozycki" <macro@linux-mips.org>
Cc: Frederic Krueger <spamalltheway@bigfoot.com>,
	lkml <linux-kernel@vger.kernel.org>
Subject: Re: io apic + tsc = slowdown (bugreport + possible fix)
Date: Tue, 29 Jun 2004 11:52:58 -0700	[thread overview]
Message-ID: <1088534977.1388.3.camel@cog.beaverton.ibm.com> (raw)
In-Reply-To: <Pine.LNX.4.55.0406291358010.31801@jurand.ds.pg.gda.pl>

On Tue, 2004-06-29 at 05:07, Maciej W. Rozycki wrote:
> On Mon, 28 Jun 2004, john stultz wrote:
> 
> > Looking closer at the proposed workaround by Maciej posted here:
> > http://linux.derkeiler.com/Mailing-Lists/Kernel/2004-04/3174.html
> > 
> > Why exactly are we using cpu_has_tsc to switch this? I'm not sure I'm
> > following how this is TSC dependent. Additionally the comment change
> > looks to be from the 2.4 era. 
> 
>  One of the two users of timer_ack is do_slow_gettimeoffset().  When the
> TSC is selected for use as a high-precision timer do_fast_gettimeoffset()
> is used instead.
> 
>  Please folks do read the sources sometimes -- I've been repeatedly
> clarifying these bits while they are all documented in the sources,
> sigh...

Whoops, sorry, I had the impression the patch was targeted against 2.6,
where there is no do_slow_gettimeoffset() and the only user of timer_ack
is in do_timer_interrupt(). 

So am I incorrect that the TSC bits can be dropped for the 2.6 version
of the patch?

thanks
-john



  reply	other threads:[~2004-06-29 18:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-06-28  7:27 Frederic Krueger
2004-06-29  0:06 ` john stultz
2004-06-29 12:07   ` Maciej W. Rozycki
2004-06-29 18:52     ` john stultz [this message]
2004-06-29 19:11       ` Maciej W. Rozycki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1088534977.1388.3.camel@cog.beaverton.ibm.com \
    --to=johnstul@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=macro@linux-mips.org \
    --cc=spamalltheway@bigfoot.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®