From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753305AbbCJTwJ (ORCPT ); Tue, 10 Mar 2015 15:52:09 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:65042 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751737AbbCJTwH convert rfc822-to-8bit (ORCPT ); Tue, 10 Mar 2015 15:52:07 -0400 From: Arnd Bergmann To: Kumar Gala Cc: Olof Johansson , Kevin Hilman , linux-arm-msm , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "arm@kernel.org" , "devicetree@vger.kernel.org" , Heiko =?ISO-8859-1?Q?St=FCbner?= Subject: Re: [PATCH v2 1/3] devicetree: bindings: Document qcom,msm-id and qcom,board-id Date: Tue, 10 Mar 2015 20:52:01 +0100 Message-ID: <10886228.vUHyKm1ubP@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <3A588B25-66ED-4BB5-8C8F-D050D8A2F9F3@codeaurora.org> References: <1425503602-24916-1-git-send-email-galak@codeaurora.org> <3A588B25-66ED-4BB5-8C8F-D050D8A2F9F3@codeaurora.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="utf-8" X-Provags-ID: V03:K0:stZKqJyyjiZMYijLXYwu7V9g1bP1zyxXksgjS6YOD+vnzdSTvXC DvjU7bnl+nH0IlsVo84gk2Ais7nTmUFTtVQIrMWM+/QcYJcZ7Sc1bQ6x55vJorO7cOQOLKj 5RhcJLHxCoq8xN+V8mUP2R05Nrp99j2EuvGCJn343Gcfqv1k/tFyqCHYKwQz9LbXWPGEzbH 0i4dwuSjFN8rsMMbHb3Hg== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 10 March 2015 13:10:08 Kumar Gala wrote: > >>>>>>>>> The top level qcom,msm-id and qcom,board-id are utilized by bootloaders > >>>>>>>>>> on Qualcomm MSM platforms to determine which device tree should be > >>>>>>>>>> utilized and passed to the kernel. > >>>>>>>>>> > >>>>>>>>>> Cc: > >>>>>>>>>> Signed-off-by: Kumar Gala > >>>>>>>>> > >>>>>>>>> Is this the special magic that allows qcom bootloaders to take a kernel > >>>>>>>>> plus multiple DTBs and figure out which DTB to pass? > >>>>>>>>> > >>>>>>>>> Kevin > >>>>>>>> > >>>>>>>> yes > >>>>>>> > >>>>>>> That's a bummer. > >>>>>>> > >>>>>>> Luckily, the solution for upstream is still quite simple: Provide only > >>>>>>> one devicetree, and it'll be used, right? > >>>>>> > >>>>>> We can provide only one, we still need the IDs in the DT. > >>>>> > >>>>> How are the DTS provided? Concatenated with the kernel, or in a > >>>>> wrapped data format? Or in a separate partition from the kernel? > >>>> > >>>> Its a wrapped data format that is than concatenated with the kernel if I remember correctly. > >>> > >>> Then you should be able to create a tool that can write this concatenated > >>> format and insert these properties from a table that matches the boot > >>> loader, right? > >>> > >>> Arnd > >> > >> Are you suggesting the tool insert the properties in the DT? I’m not sure I understand what the point of doing that would be. > > > > To insert platform-local properties that mean nothing outside of the > > firmware packaging of the device trees, which is the case here? > > > > I think the idea of having the installer script inserting them is > > quite reasonable in this case. > > > > > > -Olof > > These values are static, so not sure what the point of having the installer script do that? > It combines two hacks to work around a nonstandard boot loader. Once the bootloader is fixed, you can stop using that script. Arnd