From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Pavel Machek <pavel@suse.cz>
Cc: Linus Torvalds <torvalds@osdl.org>,
vojtech@suse.cz, James Bottomley <James.Bottomley@SteelEye.com>,
Andrew Morton <akpm@osdl.org>, Paul Jackson <pj@sgi.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
PARISC list <parisc-linux@lists.parisc-linux.org>
Subject: Re: [parisc-linux] Re: [PATCH] Fix the cpumask rewrite
Date: Thu, 01 Jul 2004 15:07:03 +0100 [thread overview]
Message-ID: <1088690821.4621.11.camel@localhost.localdomain> (raw)
In-Reply-To: <20040701131158.GP698@openzaurus.ucw.cz>
On Iau, 2004-07-01 at 14:11, Pavel Machek wrote:
> Heh, with vojtech we introduced locking into input layer
> (there was none before)... using test_bit/set_bit.
>
> (I just hope set_bit etc implies memory barrier... or we'll have to do
> it once more)
It doesn't - the ppp layer got burned badly by this long ago. set_bit is
not a memory barrier. OTOH you can just add an mb()
With respect to the need for a get_jiffies API I don't think you
do need it for ratelimit.
static DECLARE_TIMEOUT_EXPIRED(printk_timer);
if(timeout_expired(t))
{
printk("Blah");
timeout_set(t, 5 * HZ);
}
if we followed the way MUTEX and the other defines work.
next prev parent reply other threads:[~2004-07-01 15:10 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-26 16:08 James Bottomley
2004-06-26 16:32 ` Linus Torvalds
2004-06-26 16:44 ` Linus Torvalds
2004-06-26 16:46 ` James Bottomley
2004-06-26 16:54 ` Linus Torvalds
2004-06-26 17:18 ` James Bottomley
2004-06-26 18:01 ` Linus Torvalds
2004-06-26 18:28 ` Vojtech Pavlik
2004-06-26 18:54 ` Linus Torvalds
2004-06-26 19:02 ` James Bottomley
2004-06-26 19:13 ` Linus Torvalds
2004-06-26 19:13 ` Vojtech Pavlik
2004-06-26 18:59 ` James Bottomley
2004-06-26 19:11 ` Linus Torvalds
2004-06-26 19:33 ` James Bottomley
2004-06-28 23:16 ` Jonathan Lundell
2004-07-01 13:11 ` Pavel Machek
2004-07-01 14:07 ` Alan Cox [this message]
2004-07-01 16:15 ` [parisc-linux] " Linus Torvalds
2004-07-01 16:52 ` Jeff Garzik
2004-07-01 17:42 ` Linus Torvalds
2004-06-26 22:18 ` Chris Wedgwood
2004-06-26 22:48 ` Linus Torvalds
2004-06-26 22:54 ` [parisc-linux] " Alan Cox
2004-06-27 0:05 ` Chris Wedgwood
2004-06-27 12:00 ` Matthias Urlichs
2004-06-27 22:41 ` Chris Wedgwood
2004-06-28 1:24 ` Matthias Urlichs
2004-06-28 5:42 ` Chris Wedgwood
2004-06-28 6:55 ` Matthias Urlichs
2004-06-28 7:02 ` Chris Wedgwood
2004-06-28 7:19 ` Matthias Urlichs
2004-06-27 14:37 ` Alan Cox
2004-07-01 13:33 ` Pavel Machek
2004-07-01 17:43 ` Chris Wedgwood
2004-06-26 23:37 ` jiffies_64 Chris Wedgwood
2004-06-27 1:55 ` more (insane) jiffies ranting Chris Wedgwood
2004-06-27 17:39 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1088690821.4621.11.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=James.Bottomley@SteelEye.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=parisc-linux@lists.parisc-linux.org \
--cc=pavel@suse.cz \
--cc=pj@sgi.com \
--cc=torvalds@osdl.org \
--cc=vojtech@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®