From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E76C31063B for ; Wed, 10 Sep 2025 08:35:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757493319; cv=none; b=GwH80I6iN/nGEsKAYvGs7yoGpXO8gG2AVEE89bdNs3rbbgrDhBTEuue5nDzw6okH3w3K5WnTnHHYElVAFDnTfx2o9WUjUqaSltdgKV7dw3uSmj8jWwTTiwLBmHIv3tR/ea0V37H9iWcH/bKUbz0L4vObFnfo2ykfFHf0YMcrJIk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757493319; c=relaxed/simple; bh=6pBqardOFH33jygFUEKtPxkKJseqnqQZsdOrvgwU+5Y=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=PwzrBSoZ4gLSjZ0rYJlJPgQqlkImkkBzggy6Q5sX2P9zReZRLmEn6iikOHWlh5mwOnD6HTQSWiGr+uaQwR58fwYv2LysLdMP8rPne/LwqmbzVtgjwziJZMfoC9+2GPaYK6hYUJjfmbIS9m3VZbOOoUsbafXKDHNxYqC3RMzdZ2Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=m7kf9Hgn; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="m7kf9Hgn" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 58A7cj4r002880 for ; Wed, 10 Sep 2025 08:35:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= mdZlGbXkoykBItIhC2uuPRcWMxj3GO69cBZWAldVw3M=; b=m7kf9HgnKQ/9rzas V97f3QsliMHcaYhWLmqyotcd0N5a2Nc+TwfOuH5XZv5YwYmEy8Xjh934QM8uAD3o TIvq0cALJVZadIZEnlNdEWVONaZpEtMPGqoFEMXlHYxWHLfz5EE63RDMhjRTM74v 7GCvYtr+wgpdagFTCDTSYzPwflzD5eSPRkUY7Di0CtSKvdP1K7zXFGan3lAbly1i lB7QtZZe+uFapwsmom7T2nrCRMMOzPgGpg0fD7KyO/OEzrvQ10yGnDzhTs55ZYJo 81l4sA8n4cDZ6ECkANElJncW6OUleHppTwnX3GTz6qbg3t+mSoDT9CuX4urb9Xrw F678AQ== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 490e8ab32y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 10 Sep 2025 08:35:17 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-4b604c02383so16304771cf.2 for ; Wed, 10 Sep 2025 01:35:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757493314; x=1758098114; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mdZlGbXkoykBItIhC2uuPRcWMxj3GO69cBZWAldVw3M=; b=m7BKTh00fcrULrgWnZcOP5R1vUsej0vONhw0NHkHbT1sfl9/ETPRQyzNcIgVFzKOxX JXFfgqxmi0unhf6+zibNDj/G6J5NEO3IWC0u06EQ60SUPMbUXdS0zfcHoivb+KVMRUQd uyj45INaXSb4O574OX2hxsblzI3gF4y6VI49Tqq9N3eiKjibWnDafprOU4rFacfG3ddO SUOIDU8oABxG1iQW2m5/o0ASWEJHrMWmLe4lOufHb14/3RONYIlrcNt7nhQL36QLispH rjzRoQlE6CTlUSeyJ5SY62ga7LEC/P/4k3yQoe7/LX/YdhTnFVVW1q7meYFHSztyAkxW zeSQ== X-Forwarded-Encrypted: i=1; AJvYcCWFe9cl3xKzkP9eVMl2Sq2JqlnYFqJXUqEyFI8gT9vJnbGPo+hh/Ngy/wyrN3A66hGfV3DO+8hj3+NbxtU=@vger.kernel.org X-Gm-Message-State: AOJu0YwIinKAUNwxruJ8WPmDi4wRgIb0Ghqa8iKKicRHdgBZyKshI1me y0OlVuDapwLNarhiZnhTXTqlbvcUOkgmWslvk5WTWPq3ZehlqMLpuGOyvO2i9VllWFrRjiIer3C LvGh8uuYR3TbVA1vCaYjpdtbFS3zzOBpmjTKPsgHODTAQ4uIubx28Wj8uqGT7qknJt10= X-Gm-Gg: ASbGncvQtIxWsMyeq2TUbcCIUsGVAMpgxAR6YN9r8J/mFnq4hX6dOYh89q/ERJlMwf/ /8+7pMW8TPkOuPEW5t3K7kCSI+ycC4qDvZJrRWTI83lgJdmfXx1mi7veEMjo/BUsKwWkTVH7WhQ d3wdVkH7oEdi3NnKISE1NVMzKTnc9B2b6b8uAQ/5iINVdDUAglggjR6wrWe05QHdZyTIY82HPyB J0p5KsvdeKd/UA+GKRWfjdKECAVuCepOhWkE7nlymzKY2vjGRp0WEqYRsUYnU4yu0mhu5SzCn0E GZS410flgWSvG9AOucHhPNvNp5ntqTTUoIZoLQf3XuC9AbBNiFswpMiTMQV9Zm4gqfOoF/jdGnL 7jOs5ZV9//QjNhTxJJME9hQ== X-Received: by 2002:a05:622a:f:b0:4b3:d2c:f2a0 with SMTP id d75a77b69052e-4b5f84608a1mr93692711cf.11.1757493313959; Wed, 10 Sep 2025 01:35:13 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGC/PjlyjlapeA2UUFv3VPSLLeX8X1TPLj4/Upo+NAPNfgy876iYhaAOrUk5Om4jVsYgaP3RA== X-Received: by 2002:a05:622a:f:b0:4b3:d2c:f2a0 with SMTP id d75a77b69052e-4b5f84608a1mr93692431cf.11.1757493313260; Wed, 10 Sep 2025 01:35:13 -0700 (PDT) Received: from [192.168.149.223] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b078340e5bdsm127895366b.97.2025.09.10.01.35.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Sep 2025 01:35:12 -0700 (PDT) Message-ID: <108895ac-0c4d-4aee-86b1-96461e00def3@oss.qualcomm.com> Date: Wed, 10 Sep 2025 10:35:09 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/4] dt-bindings: leds: add generic LED consumer documentation To: Hans de Goede , Aleksandrs Vinarskis , Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bryan O'Donoghue , Daniel Thompson , Jingoo Han , Mauro Carvalho Chehab , Jean-Jacques Hiblot , Jacopo Mondi , Sakari Ailus , Bjorn Andersson , Konrad Dybcio Cc: linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Daniel Thompson , dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20250908-leds-v3-0-5944dc400668@vinarskis.com> <20250908-leds-v3-1-5944dc400668@vinarskis.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=H7Dbw/Yi c=1 sm=1 tr=0 ts=68c13845 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=yJojWOMRYYMA:10 a=gEfo2CItAAAA:8 a=I76Qk8w-AAAA:8 a=bzamcEsfLQq8zZigF6MA:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 a=sptkURWiP4Gy88Gu7hUp:22 a=vUPM0Wvl0xcrLs4nqPIT:22 X-Proofpoint-GUID: 9suZJ_aF5dWgnDL-ZH91dVBUAoC2CmMb X-Proofpoint-ORIG-GUID: 9suZJ_aF5dWgnDL-ZH91dVBUAoC2CmMb X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwOTA2MDAzOSBTYWx0ZWRfX4wv35SLo4y6z GBcLcduvlrcsDlIvPLNKOmEBFmojcymPNl7Z+VCW5IPX5XufnXOO0o4WBoQYqvAaJSdiTte84z7 sHWdeanbH4coUMDhvxN92BXnDv/bi+GKqKIcFcr3hR7rpeic6Z8srGeUGYrY5CVKVtPzdhk7M5l EChEgZamIGAQWKsRVvrX08042O2padFr2S0S5riqU747LvFk3ViaGDUB0K5HuLUPIfWErmk++AU 5tAL4HxZdOOkzEAjpA1/sxGo47iPUxoFgSUWW47zyrsVS6FIv925Kk0LFg72EXLhcU+Mfibv9TU yCDjnztKgKSOZvcx4iDvBgwxioyWTl/4QaPshuAyOJ8cnD/qLaB8UsISj1dsWHd/pXI69wg/93u 156ghg0l X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1117,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-09-09_03,2025-09-10_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 bulkscore=0 impostorscore=0 adultscore=0 phishscore=0 clxscore=1015 suspectscore=0 priorityscore=1501 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2509060039 On 9/9/25 10:39 PM, Hans de Goede wrote: > Hi, > > On 9-Sep-25 6:57 PM, Aleksandrs Vinarskis wrote: >> >> >> >> >> >> On Monday, September 8th, 2025 at 01:18, Aleksandrs Vinarskis wrote: >> >>> >>> >>> Introduce common generic led consumer binding, where consumer defines >>> led(s) by phandle, as opposed to trigger-source binding where the >>> trigger source is defined in led itself. >>> >>> Add already used in some schemas 'leds' parameter which expects >>> phandle-array. Additionally, introduce 'led-names' which could be used >>> by consumers to map LED devices to their respective functions. >>> >>> Signed-off-by: Aleksandrs Vinarskis alex@vinarskis.com >>> >>> --- >>> .../devicetree/bindings/leds/leds-consumer.yaml | 89 ++++++++++++++++++++++ >>> 1 file changed, 89 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/leds/leds-consumer.yaml b/Documentation/devicetree/bindings/leds/leds-consumer.yaml >>> new file mode 100644 >>> index 0000000000000000000000000000000000000000..d50a3850f6336e9e3a52eb1374e36ea50de27f47 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/leds/leds-consumer.yaml >>> @@ -0,0 +1,89 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/leds/leds-consumer.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: Common leds consumer >>> + >>> +maintainers: >>> + - Aleksandrs Vinarskis alex@vinarskis.com >>> >>> + >>> +description: >>> + Some LED defined in DT are required by other DT consumers, for example >>> + v4l2 subnode may require privacy or flash LED. Unlike trigger-source >>> + approach which is typically used as 'soft' binding, referencing LED >>> + devices by phandle makes things simpler when 'hard' binding is desired. >>> + >>> + Document LED properties that its consumers may define. >>> + >>> +select: true >>> + >>> +properties: >>> + leds: >>> + oneOf: >>> + - type: object >>> + - $ref: /schemas/types.yaml#/definitions/phandle-array >>> + description: >>> + A list of LED device(s) required by a particular consumer. >>> + items: >>> + maxItems: 1 >>> + >>> + led-names: >> >> While going over the feedback I realized `leds` and `led-names` do >> not follow `property`, `property-names` convention. Any objections >> if I rename `led-names` to `leds-names` for consistency? > > No objections from me, `leds-names` indeed is better. FWIW we have "clocks"/"clock-names", "resets"/"reset-names" etc. I sometimes refer to "property"/"property-names" during review to bring attention to the preferred style (ordering of such entries), which is maybe what confused you Konrad