From: Dave Kleikamp <shaggy@austin.ibm.com>
To: Tom Dickson <tdickson@inostor.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: What is the BUG() call in ll_rw_blk.c (2.4.26) for?
Date: Wed, 21 Jul 2004 15:27:42 -0500 [thread overview]
Message-ID: <1090441662.17490.28.camel@shaggy.austin.ibm.com> (raw)
In-Reply-To: <40FEB7B8.2050501@inostor.com>
On Wed, 2004-07-21 at 13:36, Tom Dickson wrote:
> void submit_bh(int rw, struct buffer_head * bh)
> {
> ~ int count = bh->b_size >> 9;
>
>
> ~ if (!test_bit(BH_Lock, &bh->b_state))
> ~ BUG();
>
> Does anyone know what that BUG(); is testing? We're seeing it and want
> to track down what we're doing that is causing it.
You must lock the buffer_head before calling submit_bh. If the
buffer_head is not locked, you see the BUG.
Shaggy
--
David Kleikamp
IBM Linux Technology Center
prev parent reply other threads:[~2004-07-21 20:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-21 18:36 Tom Dickson
2004-07-21 20:27 ` Dave Kleikamp [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1090441662.17490.28.camel@shaggy.austin.ibm.com \
--to=shaggy@austin.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tdickson@inostor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®