From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F39BCC433EF for ; Mon, 11 Apr 2022 12:35:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346140AbiDKMhz (ORCPT ); Mon, 11 Apr 2022 08:37:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42964 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346134AbiDKMhd (ORCPT ); Mon, 11 Apr 2022 08:37:33 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 79F2B1B789 for ; Mon, 11 Apr 2022 05:35:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1649680518; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9lC0yv022i0CueqKYelOpTAIE5sprvHncsYQxz3lXPE=; b=Htkb5rlS7qXrEaBijnil9Lzd8OkNCtUx80GpZQaVuEllpf4zJQbiQpYnKvjURrBOF+HDVi OX4BKp22kAdy7UreSOMr828jDzO+oxXWd0i+IbSpLzc2Y5hA40ojlmohtmCejhQS7DAI0J 6RwVnm28pANjT5IYp7y7XrFYHpQC1R4= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-449-ZPIfAO1VN8qxKXuAQn97-Q-1; Mon, 11 Apr 2022 08:35:12 -0400 X-MC-Unique: ZPIfAO1VN8qxKXuAQn97-Q-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7E6AE803D67; Mon, 11 Apr 2022 12:35:11 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.37.45]) by smtp.corp.redhat.com (Postfix) with ESMTP id 166A2C2813D; Mon, 11 Apr 2022 12:35:08 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20220406075612.60298-5-jefflexu@linux.alibaba.com> References: <20220406075612.60298-5-jefflexu@linux.alibaba.com> <20220406075612.60298-1-jefflexu@linux.alibaba.com> To: Jeffle Xu Cc: dhowells@redhat.com, linux-cachefs@redhat.com, xiang@kernel.org, chao@kernel.org, linux-erofs@lists.ozlabs.org, torvalds@linux-foundation.org, gregkh@linuxfoundation.org, willy@infradead.org, linux-fsdevel@vger.kernel.org, joseph.qi@linux.alibaba.com, bo.liu@linux.alibaba.com, tao.peng@linux.alibaba.com, gerry@linux.alibaba.com, eguan@linux.alibaba.com, linux-kernel@vger.kernel.org, luodaowen.backend@bytedance.com, tianzichen@kuaishou.com, fannaihao@baidu.com Subject: Re: [PATCH v8 04/20] cachefiles: notify user daemon when withdrawing cookie MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1091404.1649680508.1@warthog.procyon.org.uk> Date: Mon, 11 Apr 2022 13:35:08 +0100 Message-ID: <1091405.1649680508@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.85 on 10.11.54.8 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jeffle Xu wrote: > +static int init_close_req(struct cachefiles_req *req, void *private) "cachefiles_" prefix please. > + /* > + * It's possible if the cookie looking up phase failed before READ > + * request has ever been sent. > + */ What "it" is possible? You might want to say "It's possible that the cookie..." > + if (fd == 0) > + return -ENOENT; 0 is a valid fd. David