On Mon, 2004-07-26 at 21:18, Ram Pai wrote: > On Mon, 2004-07-26 at 17:08, Andrew Morton wrote: > > Ram Pai wrote: > > > > > > Andrew, > > > Yes the patch fixes a valid bug. > > > > > > > Please don't top-post :( > > > RP > > > > > > On Mon, 2004-07-26 at 16:29, Andrew Morton wrote: > > > > Miklos Szeredi wrote: > > > > > > > > > > Current readahead logic is broken when a random read pattern is > > > > > followed by a long sequential read. The cause is that on a window > > > > > miss ra->next_size is set to ra->average, but ra->average is only > > > > > updated at the end of a sequence, so window size will remain 1 until > > > > > the end of the sequential read. > > > > > > > > > > This patch fixes this by taking the current sequence length into > > > > > account (code taken from towards end of page_cache_readahead()), and > > > > > also setting ra->average to a decent value in handle_ra_miss() when > > > > > sequential access is detected. > > > > > > > > Thanks. Do you have any performance testing results from this patch? > > > > > > > Ram Pai wrote: > > > > > > Andrew, > > > Yes the patch fixes a valid bug. > > > > Fine, but the readahead code is performance-sensitive, and it takes quite > > some time for any regressions to be discovered. So I'm going to need to > > either sit on this patch for a very long time, or extensively test it > > myself, or await convincing test results from someone else. > > > > Can you help with that? > > yes I will run all my standard testsuites before we take this patch. > (DSS workload, iozone, sysbench). I will get back with some results > sooon. Probably by the end of this week. Ok I have enclosed the results. The summary is: there is no significant improvement or decrease in performance of (DSS workload, iozone, sysbench) The increase or decrease is in the margin of errors. I have also enclosed a patch that partially backs off Miklos's fix. Shane Shrybman correctly pointed out that the real fix is to set ra->average value to max/2 when we move from readahead-off mode to readahead-on mode. The other part of Miklos's fix becomes irrelevent. Sorry it took some time to get back on this. Its almost automated so turnaround time should be quick now-on-wards. RP