From: Paul Fulghum <paulkf@microgate.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] 2.6.8 synclink_cs.c replace syncppp with genhdlc
Date: 16 Aug 2004 10:58:02 -0500 [thread overview]
Message-ID: <1092671882.2012.16.camel@deimos.microgate.com> (raw)
In-Reply-To: <20040816162158.A11863@infradead.org>
On Mon, 2004-08-16 at 10:21, Christoph Hellwig wrote:
> > +#ifdef CONFIG_HDLC_MODULE
> > +#define CONFIG_HDLC 1
> > #endif
>
> shouldn't the drivers depend on hdlc instead?
They do.
When hdlc is enabled as a module:
CONFIG_HDLC_MODULE is defined
CONFIG_HDLC is not defined
When hdlc is enabled in kernel:
CONFIG_HDLC_MODULE is not defined
CONFIG_HDLC is defined
The HDLC interface in the synclink modules need
to be enabled for either case.
All the conditional compilation is done
on CONFIG_HDLC, and the above fragment
defines CONFIG_HDLC when HDLC is built as a
module.
Is there a better way of handling this?
--
Paul Fulghum
paulkf@microgate.com
prev parent reply other threads:[~2004-08-16 16:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-16 15:11 Paul Fulghum
2004-08-16 15:21 ` Christoph Hellwig
2004-08-16 15:58 ` Paul Fulghum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1092671882.2012.16.camel@deimos.microgate.com \
--to=paulkf@microgate.com \
--cc=akpm@osdl.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome