From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: Ray Lehtiniemi <rayl@mail.com>,
Linus Torvalds <torvalds@osdl.org>,
Charles Lever <Charles.Lever@netapp.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: nfsroot compile broken in 2.6.9-rc1?
Date: Tue, 24 Aug 2004 13:27:59 -0400 [thread overview]
Message-ID: <1093368479.5745.72.camel@lade.trondhjem.org> (raw)
In-Reply-To: <20040824165002.GA4314@mail.com>
På ty , 24/08/2004 klokka 12:50, skreiv Ray Lehtiniemi:
> just pulled the latest changes, and it seems nfsroot no longer
> compiles:
>
> CC fs/nfs/nfsroot.o
> fs/nfs/nfsroot.c: In function `root_nfs_get_handle':
> fs/nfs/nfsroot.c:499: error: cannot convert to a pointer type
> fs/nfs/nfsroot.c:499: error: cannot convert to a pointer type
> make[2]: *** [fs/nfs/nfsroot.o] Error 1
Chuck, that conversion to nfs_fh_copy() is bogus since we're not copying
into an nfs_fh anyway. Let's just revert it.
Cheers,
Trond
--- linux-2.6.9-up/fs/nfs/nfsroot.c.orig 2004-08-24 11:18:27.000000000 -0400
+++ linux-2.6.9-up/fs/nfs/nfsroot.c 2004-08-24 13:18:32.000000000 -0400
@@ -495,8 +495,10 @@ static int __init root_nfs_get_handle(vo
if (status < 0)
printk(KERN_ERR "Root-NFS: Server returned error %d "
"while mounting %s\n", status, nfs_path);
- else
- nfs_copy_fh(nfs_data.root, fh);
+ else {
+ nfs_data.root.size = fh.size;
+ memcpy(nfs_data.root.data, fh.data, fh.size);
+ }
return status;
}
next prev parent reply other threads:[~2004-08-24 17:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-24 16:50 Ray Lehtiniemi
2004-08-24 17:27 ` Trond Myklebust [this message]
2004-08-25 13:08 Lever, Charles
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1093368479.5745.72.camel@lade.trondhjem.org \
--to=trond.myklebust@fys.uio.no \
--cc=Charles.Lever@netapp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rayl@mail.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®