mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: john stultz <johnstul@us.ibm.com>
To: lkml <linux-kernel@vger.kernel.org>
Cc: William Lee Irwin III <wli@holomorphy.com>,
	James <jamesclv@us.ibm.com>, keith maanthey <kmannth@us.ibm.com>,
	Chris McDermott <lcm@us.ibm.com>,
	"Martin J. Bligh" <mbligh@aracnet.com>
Subject: [RFC][PATCH] fix target_cpus() for summit subarch
Date: Fri, 27 Aug 2004 17:24:48 -0700	[thread overview]
Message-ID: <1093652688.14662.16.camel@cog.beaverton.ibm.com> (raw)

I've been hunting down a bug affecting IBM x440/x445 systems where the
floppy driver would get spurious interrupts and would not initialize
properly. 

After digging James Cleverdon pointed out that target_cpus() is routing
the interrupts to the clustered apic broadcast mask. This was causing
multiple interrupts to show up, breaking the floppy init code. 

This one-liner fix simply routes interrupts to the first cpu to resolve
this issue.

Any comments or feedback would be appreciated.

thanks
-john

===== include/asm-i386/mach-summit/mach_apic.h 1.38 vs edited =====
--- 1.38/include/asm-i386/mach-summit/mach_apic.h	2004-06-24 01:55:52 -07:00
+++ edited/include/asm-i386/mach-summit/mach_apic.h	2004-08-27 16:43:22 -07:00
@@ -19,7 +19,7 @@
 
 static inline cpumask_t target_cpus(void)
 {
-	return CPU_MASK_ALL;
+	return cpumask_of_cpu(0);
 } 
 #define TARGET_CPUS	(target_cpus())
 



             reply	other threads:[~2004-08-28  0:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-28  0:24 john stultz [this message]
2004-08-28  2:02 ` William Lee Irwin III
2004-08-28  6:17 ` Martin J. Bligh
2004-08-30 18:03   ` john stultz
2004-08-30 20:46     ` john stultz
2004-08-30 21:24     ` James Cleverdon
2004-08-31  1:06       ` john stultz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1093652688.14662.16.camel@cog.beaverton.ibm.com \
    --to=johnstul@us.ibm.com \
    --cc=jamesclv@us.ibm.com \
    --cc=kmannth@us.ibm.com \
    --cc=lcm@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mbligh@aracnet.com \
    --cc=wli@holomorphy.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®