From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753981AbaGUI6N (ORCPT ); Mon, 21 Jul 2014 04:58:13 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:58098 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753927AbaGUI6K (ORCPT ); Mon, 21 Jul 2014 04:58:10 -0400 From: Arnd Bergmann To: Chanwoo Choi Cc: linux-arm-kernel@lists.infradead.org, jic23@kernel.org, ch.naveen@samsung.com, mark.rutland@arm.com, devicetree@vger.kernel.org, kgene.kim@samsung.com, pawel.moll@arm.com, ijc+devicetree@hellion.org.uk, linux-iio@vger.kernel.org, t.figa@samsung.com, rdunlap@infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, kyungmin.park@samsung.com, robh+dt@kernel.org, galak@codeaurora.org Subject: Re: [PATCHv7 0/4] iio: adc: exynos_adc: Support Exynos3250 ADC and code clean Date: Mon, 21 Jul 2014 10:57:35 +0200 Message-ID: <10938575.0qbHyHWX4J@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.11.0-18-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <53CCCB20.50802@samsung.com> References: <1405909068-22539-1-git-send-email-cw00.choi@samsung.com> <14522743.f6oFhEQVv4@wuerfel> <53CCCB20.50802@samsung.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V02:K0:ukQlI39N6U5i5ov1YBiCr9GVqJvxyVYDk8HqeuLldHd KDGsEDQAcJY5oUQ8FAv0mez3f3FKQDlPqGA8MX1ah7nCyeIGwk E0+xGfFqFb8Wm9tc82nPelqOaTaaa7rQLyHc8Iv01l2u90s7Hf jt28zEUipuYcOS/9U/Ku6r6VOy3BJRMEy5kf0tPe8VVm04kKIu khepxMFmeZpzr09yIjEnB0zq2RQca1SCUL5QHpadWjDktrNSJY kbHKi4LdPPltoIOIN7D8VB23vD6yh1cheSk5u8K0cadyIAui5I qQ7c4AkLkfzHiXMTWZH4V14f3r90Up5ncHFr2azYN0Gtzxp56y EHwd++XrdfsQRiJexbyw= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 21 July 2014 17:11:12 Chanwoo Choi wrote: > > work to address the comments and do testing. > > OK, I'll add this patch. > But, I have a question. > > Your patch add following compatible string. > "s3c64100-adc" is right? > > static const struct of_device_id exynos_adc_match[] = { > { > + .compatible = "samsung,s3c64100-adc", > + .data = &exynos_adc_s3c64xx_data, > + }, { There is a typo, thanks for spotting this. It should be "samsung,s3c6410-adc", not "samsung,s3c64100-adc". > > b) For the "compatible" string, I think it makes sense to set a fallback to > > "samsung,exynos-adc-v2" in the case for exynos3250, making the DT > > representation > > > > compatible = "samsung,exynos3250-adc", "samsung,exynos-adc-v2"; > > > > It's not entirely compatible because of the addition of the clock, but > > since the register layout is the same, I think it still make sense. > > OK, I'll add it in exynos3250.dtsi as following: > > adc: adc@126C0000 { > - compatible = "samsung,exynos-adc-v3"; > + compatible = "samsung,exynos3250-adc", > + "samsung,exynos-adc-v2"; > reg = <0x126C0000 0x100>, <0x10020718 0x4>; > interrupts = <0 137 0>; > - clock-names = "adc", "sclk_tsadc"; > + clock-names = "adc", "sclk"; > clocks = <&cmu CLK_TSADC>, <&cmu CLK_SCLK_TSADC>; > #io-channel-cells = <1>; > io-channel-ranges; Ok, looks good. Arnd