From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S268164AbUHaMk5 (ORCPT ); Tue, 31 Aug 2004 08:40:57 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S268144AbUHaMk5 (ORCPT ); Tue, 31 Aug 2004 08:40:57 -0400 Received: from the-village.bc.nu ([81.2.110.252]:6791 "EHLO localhost.localdomain") by vger.kernel.org with ESMTP id S268162AbUHaMkw (ORCPT ); Tue, 31 Aug 2004 08:40:52 -0400 Subject: Re: Driver retries disk errors. From: Alan Cox To: James Courtier-Dutton Cc: "Theodore Ts'o" , Rogier Wolff , Linux Kernel Mailing List , linux-ide@vger.kernel.org In-Reply-To: <41337153.60505@superbug.demon.co.uk> References: <20040830163931.GA4295@bitwizard.nl> <20040830174632.GA21419@thunk.org> <41337153.60505@superbug.demon.co.uk> Content-Type: text/plain Content-Transfer-Encoding: 7bit Message-Id: <1093952325.32684.7.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.6 (1.4.6-2) Date: Tue, 31 Aug 2004 12:38:45 +0100 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Llu, 2004-08-30 at 19:26, James Courtier-Dutton wrote: > Theodore Ts'o wrote: > > If the block gets successfully read after 2 or 3 tries, it might be a > > good idea for the kernel to automatically do a forced rewrite of the > > block, which should cause the disk to do its own disk block > > sparing/reassignment. Not really as far as I can tell. It isn't a disk any more, its a storage appliance on a funny connector. It already knows a lot about retries internally as well as rewriting blocks with high ECC error count. In fact you actually have to issue a different command to do read/write without retry. > It does the same retries with CD-ROM and DVDs, and if the retries fail, > it disables DMA! It even does the retries when reading CD-Audio. > Maybe there should be a "retrys" setting that can be set by hdparm, then > we could set the retry counts, and what happens when a retry fails on a > per device basis. It probably should be smarter about error strategy here. You can use hdparm to control some of this in the IDE case but not enough. Alan