mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Proposal: Changing enable_irq/disable_irq to be two argument.
Date: Thu, 02 Sep 2004 13:36:08 +0100	[thread overview]
Message-ID: <1094128566.4966.30.camel@localhost.localdomain> (raw)

I've been putting together some patches to deal with stuck interrupts
more intelligently. Instead of just deciding an interrupt is stuck the
code tries to respond to stuck interrupts by running every shared IRQ
handler registered. This is generally safe because SHIRQ handlers have
to check if their hardware caused the interrupt anyway. It breaks for
the corner case of disable_irq() on a shared interrupt.

Fixing this needs enable/disable_irq() to take the cookie we passed to
request/free_irq. At that point we can both disable the irq and skip the
handler when doing recovery.

Even without this change the hack test version of the change is working
very well on test hardware that previously never ran Linux properly
because of broken IRQ routing tables. Clearly it needs to be a user
enabled option because it harms performance, we need to trap any bugs we
cause in this area and to continue to provide appropriate pain to
offending hardware vendors.

Alan


                 reply	other threads:[~2004-09-02 13:38 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1094128566.4966.30.camel@localhost.localdomain \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®