From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Jason Davis <jason.davis@unisys.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] 2.6.8.1 ES7000 subarch update
Date: Fri, 03 Sep 2004 12:15:21 +0100 [thread overview]
Message-ID: <1094210117.7533.28.camel@localhost.localdomain> (raw)
In-Reply-To: <20040902235214.GA21954@righTThere.net>
On Gwe, 2004-09-03 at 00:52, Jason Davis wrote:
> int mip_port;
> unsigned long mip_addr, host_addr;
>
> +EXPORT_SYMBOL(mip_reg);
> +EXPORT_SYMBOL(host_reg);
> +EXPORT_SYMBOL(mip_port);
> +EXPORT_SYMBOL(mip_addr);
> +EXPORT_SYMBOL(host_addr);
This is asking for collisions with other modules. It would be a lot
better for the future it these became e7000_mip_reg etc I think.
next prev parent reply other threads:[~2004-09-03 12:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-02 23:52 Jason Davis
2004-09-03 8:28 ` Christoph Hellwig
2004-09-03 11:15 ` Alan Cox [this message]
2004-09-03 12:32 ` Arjan van de Ven
[not found] <3010F4D7BBD5F64C9C2D17B9D17BB37705036A42@USTR-EXCH4.na.uis.unisys.com>
2004-09-10 3:15 ` Jason Davis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1094210117.7533.28.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@osdl.org \
--cc=jason.davis@unisys.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®