From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Andrew Morton <akpm@osdl.org>
Cc: Linus Torvalds <torvalds@osdl.org>,
"David S. Miller" <davem@redhat.com>,
Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: [PATCH] ppc: fix sungem NAPI (#2)
Date: Fri, 10 Sep 2004 16:20:26 +1000 [thread overview]
Message-ID: <1094797225.2667.124.camel@gaston> (raw)
Hi !
(Resent with proper signed-off line after ack from David)
The recent sungem NAPI change introduced a bug: dev_kfree_skb() is called
within the spinlock, thus triggers all sort of WARN_ON's later on down the
stack.
This patch changes it to dev_kfree_skb_any(), I hope that is fine
as we aren't really in interrupt, are we ? (I don't know in what
context NAPI polling occurs, is it a timer IRQ ?)
Ben.
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
--- 1.59/drivers/net/sungem.c 2004-09-08 06:17:59 +10:00
+++ edited/drivers/net/sungem.c 2004-09-10 13:44:18 +10:00
@@ -651,7 +651,7 @@
}
gp->net_stats.tx_packets++;
- dev_kfree_skb(skb);
+ dev_kfree_skb_any(skb);
}
gp->tx_old = entry;
reply other threads:[~2004-09-10 6:22 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1094797225.2667.124.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=akpm@osdl.org \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome