From: Alex Williamson <alex.williamson@hp.com>
To: Denis Vlasenko <vda@port.imtp.ilyichevsk.odessa.ua>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>, Linus Torvalds <torvalds@osdl.org>
Subject: Re: [PATCH] reduce [compat]_do_execve stack usage
Date: Thu, 16 Sep 2004 12:30:22 -0600 [thread overview]
Message-ID: <1095359422.5527.22.camel@tdi> (raw)
In-Reply-To: <200409151705.11356.vda@port.imtp.ilyichevsk.odessa.ua>
Looks like a couple struct to pointer conversions were missed.
Current bk won't build for me w/o this:
===== fs/compat.c 1.41 vs edited =====
--- 1.41/fs/compat.c 2004-09-14 17:24:46 -06:00
+++ edited/fs/compat.c 2004-09-16 12:19:26 -06:00
@@ -1399,11 +1399,11 @@
if (retval < 0)
goto out_mm;
- bprm.argc = compat_count(argv, bprm->p / sizeof(compat_uptr_t));
+ bprm->argc = compat_count(argv, bprm->p / sizeof(compat_uptr_t));
if ((retval = bprm->argc) < 0)
goto out_mm;
- bprm.envc = compat_count(envp, bprm->p / sizeof(compat_uptr_t));
+ bprm->envc = compat_count(envp, bprm->p / sizeof(compat_uptr_t));
if ((retval = bprm->envc) < 0)
goto out_mm;
--
Alex Williamson HP Linux & Open Source Lab
next prev parent reply other threads:[~2004-09-16 18:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-15 14:05 Denis Vlasenko
2004-09-16 18:30 ` Alex Williamson [this message]
2004-09-16 19:59 ` Denis Vlasenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1095359422.5527.22.camel@tdi \
--to=alex.williamson@hp.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
--cc=vda@port.imtp.ilyichevsk.odessa.ua \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®