From: Robert Love <rml@novell.com>
To: Bill Davidsen <davidsen@tmr.com>
Cc: Jan Kara <jack@suse.cz>, linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH] inotify 0.9
Date: Thu, 16 Sep 2004 19:22:58 -0400 [thread overview]
Message-ID: <1095376979.23385.176.camel@betsy.boston.ximian.com> (raw)
In-Reply-To: <Pine.LNX.3.96.1040916182127.20906B-100000@gatekeeper.tmr.com>
On Thu, 2004-09-16 at 18:34 -0400, Bill Davidsen wrote:
> > Maybe you should not be so fast in using your flamethrower;)
>
> I didn't intend this as a flame, but I do feel this implementation doesn't
> scale. I offered another approach off the top of my head, which appears to
> me to be more scalable. I claimed no expertise, I just made a suggestion,
> based on my first thought on how I would attack the problem in a way which
> appears more scalable.
The thing you are missing is that you absolutely have to pin something
or you have multiple VFS races. Your bitmap suggestion, while cute,
really shows a lack of understanding of the problem space.
dnotify had to do it, inotify has to do it.
Do you want to go down the lets-find-a-race path with Al Viro? ;-)
> If we are going to 4k stack because larger memory blocks are hard to find,
> I have to suspect that anything which locks up blocks size in MB is going
> to cause problems. I didn't even ask what would happen on NUMA machines,
> because that's not my usual concern.
It is not the total size that is the concern, but the per-allocation
size, which has to be contiguous. A first order allocation is hard to
do. You can only find two contiguous free pages in physical memory so
often.
Inodes come from the slabcache. NONE of this is an issue there.
Plus, as I have said, the slabcache is probably caching much of what you
are pinning. So memory consumption is not changed. Finally, these
numbers are WORST case. Watch only a handful of files and you have a
handful of hundreds of bytes pinned.
Robert Love
next prev parent reply other threads:[~2004-09-16 23:32 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-15 15:52 John McCutchan
2004-09-15 18:00 ` Robert Love
2004-09-16 15:07 ` Bill Davidsen
2004-09-16 16:27 ` Chris Friesen
2004-09-16 22:48 ` Bill Davidsen
2004-09-16 16:39 ` Robert Love
2004-09-20 20:16 ` Bill Davidsen
2004-09-20 21:05 ` Robert Love
2004-09-20 22:59 ` Bill Davidsen
2004-09-21 0:02 ` Robert Love
2004-09-16 16:46 ` Jan Kara
2004-09-16 22:34 ` Bill Davidsen
2004-09-16 22:57 ` David Lang
2004-09-16 23:22 ` Robert Love [this message]
2004-09-16 23:35 ` Alan Cox
2004-09-17 2:29 ` Robert Love
2004-09-17 3:08 ` Nicholas Miell
2004-09-17 14:39 ` Alan Cox
2004-09-17 15:48 ` Robert Love
2004-09-17 14:51 ` Alan Cox
2004-09-17 15:55 ` Robert Love
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1095376979.23385.176.camel@betsy.boston.ximian.com \
--to=rml@novell.com \
--cc=davidsen@tmr.com \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®