mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Robert Love <rml@novell.com>
To: michael_soulier@mitel.com
Cc: linux-kernel@vger.kernel.org, john_fodor@mitel.com
Subject: Re: wait_event and preemption in 2.6
Date: Fri, 08 Oct 2004 16:14:38 -0400	[thread overview]
Message-ID: <1097266478.8686.10.camel@betsy.boston.ximian.com> (raw)
In-Reply-To: <20041008174510.GJ30977@e-smith.com>

On Fri, 2004-10-08 at 13:45 -0400, michael_soulier@mitel.com wrote:

> I'm writing a device driver for PPC Linux and I'm using wait_event. It
> seems to me that there is a potential race condition in wait_event when
> preemption is turned on (2.6 kernel).
> 
> The scenario goes something like this: After the waiting process is
> woken up and returns from schedule it goes to the top of the loop and
> prepares to wait again (despite the condition being true). Then it will
> check the condition and break out of the loop. But what if in-kernel
> preemption occurs while it's doing that and another process is
> immediately scheduled to run? Does the process sleep forever? Assume
> that the event (say interrupt) that caused the original wakeup is a one
> shot.

See the PREEMPT_ACTIVE logic.

If a task is preempted it is marked PREEMPT_ACTIVE and it skips the
runqueue removal logic in schedule().  So even if it is !TASK_RUNNING it
will run again.

You can see this in schedule() and preempt_schedule(), both in
kernel/sched.c.

	Robert Love



  reply	other threads:[~2004-10-08 20:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-08 17:45 michael_soulier
2004-10-08 20:14 ` Robert Love [this message]
2004-10-08 20:24 ` Joe Korty

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1097266478.8686.10.camel@betsy.boston.ximian.com \
    --to=rml@novell.com \
    --cc=john_fodor@mitel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael_soulier@mitel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®