From: Rusty Russell <rusty@rustcorp.com.au>
To: Hirokazu Takata <takata@linux-m32r.org>
Cc: Andrew Morton <akpm@osdl.org>,
lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>,
Russell King <rmk+lkml@arm.linux.org.uk>
Subject: Re: [PATCH 2.6.9-rc3-mm2] [m32r] SIO driver for m32r
Date: Fri, 15 Oct 2004 11:27:45 +1000 [thread overview]
Message-ID: <1097803665.22673.37.camel@localhost.localdomain> (raw)
In-Reply-To: <20041006.151912.840807084.takata.hirokazu@renesas.com>
On Wed, 2004-10-06 at 16:19, Hirokazu Takata wrote:
> Hello,
>
> Here is a patch to support the M32R SIO (serial IO) driver.
> Please apply.
> +MODULE_PARM(share_irqs_sio, "i");
Hi Hirokazu!
Please use the modern "module_param(share_irqs_sio, bool, 0400)" here
(I assume you don't want this parameter to be writable, hence the 0400
permissions). MODULE_PARM is deprecated.
Thankyou!
Rusty.
--
Anyone who quotes me in their signature is an idiot -- Rusty Russell
prev parent reply other threads:[~2004-10-15 1:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-06 6:19 Hirokazu Takata
2004-10-06 7:47 ` Bernd Eckenfels
2004-10-12 9:35 ` Hirokazu Takata
2004-10-13 20:27 ` Bernd Eckenfels
2004-10-15 1:27 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1097803665.22673.37.camel@localhost.localdomain \
--to=rusty@rustcorp.com.au \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk+lkml@arm.linux.org.uk \
--cc=takata@linux-m32r.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®