On Sun, 2004-10-17 at 02:30 -0700, William Lee Irwin III wrote:
> On Sun, Oct 17, 2004 at 09:36:14AM +0200, Norbert Preining wrote:
> > @@ -1618,7 +1618,7 @@
> >         pos = (unsigned long)pdev->image_data;
> >         while (size > 0) {
> >                 page = kvirt_to_pa(pos);
> > -               if (remap_page_range(vma, start, page, PAGE_SIZE,
> >                 PAGE_SHARED))
> > +               if (remap_pfn_range(vma, start, page, PAGE_SIZE, PAGE_SHARED))
> >                         return -EAGAIN;
> >  
> >                 start += PAGE_SIZE;
> > the module compiled and loaded without problem, but when starting
> > gnomemeeting I get the following kernel BUG and scheduling while atomic:
> 
> You need to right shift the argument by PAGE_SHIFT.
> 

I am trying to get vesafb-tng to work with rc4-mm1, but are not sure
when to shift the argument by PAGE_SHIFT, and when not to.  The patches
from you in rc4-mm1 sometimes shifts the second arg, other times the
third, and other times not at all.  Is there a easy way for a mostly
clueless person to figure out when to shift what argument and when not?


Thanks,

-- 
Martin Schlemmer