On Tue, 2004-10-19 at 13:07, Ingo Molnar wrote:
> * Thomas Gleixner <tglx@linutronix.de> wrote:
> 
> > +        * Wait for the lockd process to start, but since we're holding
> > +        * the lockd semaphore, we can't wait around forever ...
> > +        */
> > +       if (wait_event_interruptible_timeout(lockd_start,
> > +                                            nlmsvc_pid != 0, HZ)) {
> > +               printk(KERN_WARNING
> > +                       "lockd_down: lockd failed to start\n");
> 
> yeah, this is much cleaner. 

Cleaner, but not perfect. The return value is > 0, if the timeout is not
reached. Grmbl.

> I'd suggest to remove the init_sem() hack
> from lib/rwsem-generic.c, it seems it is a nice facility to find
> semaphore abuses.

True. Will do so.

tglx