From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Matthew Wilcox <matthew@wil.cx>, Andrew Morton <akpm@osdl.org>,
Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>,
Alexander Viro <viro@parcelfarce.linux.theplanet.co.uk>
Subject: Re: [PATCH] lockd: replace semaphore, sleep_on
Date: Wed, 20 Oct 2004 22:24:27 +0200 [thread overview]
Message-ID: <1098303867.5390.74.camel@lade.trondhjem.org> (raw)
In-Reply-To: <20041020194522.GX16153@parcelfarce.linux.theplanet.co.uk>
> On Wed, Oct 20, 2004 at 09:15:43PM +0200, Thomas Gleixner wrote:
> >
> > Use wait_event, completion instead of the obsolete sleep_on functions
> > and the abused semaphore
What is the point of all this timeout business when starting/stopping
lockd? We sure as hell don't want lockd to survive us if we are the
process that is responsible for killing it, and neither do we want to
start locking if there is no lockd to handle callbacks.
Please see the example of rpciod in net/sunrpc/sched.c for how to do
this correctly.
As for the client changes to the GRANTED mechanism, where is
wait_for_completion_timeout() defined? It is not part of Linus' kernel.
Cheers,
Trond
--
Trond Myklebust <trond.myklebust@fys.uio.no>
prev parent reply other threads:[~2004-10-20 20:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-20 19:15 Thomas Gleixner
2004-10-20 19:45 ` Matthew Wilcox
2004-10-20 20:24 ` Trond Myklebust [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1098303867.5390.74.camel@lade.trondhjem.org \
--to=trond.myklebust@fys.uio.no \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®