From: Rusty Russell <rusty@rustcorp.com.au>
To: Takashi Iwai <tiwai@suse.de>
Cc: Andrew Morton <akpm@osdl.org>,
lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Remove MODULE_PARM from i386 defconfig.
Date: Thu, 21 Oct 2004 10:52:12 +1000 [thread overview]
Message-ID: <1098319932.10571.157.camel@localhost.localdomain> (raw)
In-Reply-To: <s5h6555iqf6.wl@alsa2.suse.de>
On Wed, 2004-10-20 at 21:23, Takashi Iwai wrote:
> Hi Rusty,
>
> At Wed, 20 Oct 2004 17:50:09 +1000,
> Rusty Russell wrote:
> > @@ -749,8 +749,8 @@ static int parport_nr[LP_NO] = { [0 ...
> > static char *parport[LP_NO] = { NULL, };
> > static int reset = 0;
> >
> > -MODULE_PARM(parport, "1-" __MODULE_STRING(LP_NO) "s");
> > -MODULE_PARM(reset, "i");
> > +module_param_array(parport, charp, NULL, 0);
>
> Can module_param_array() now take NULL for the third argument?
Yes, it was looking at the ALSA code in particular that I decided we
needed this, and hence the change. My patch cleans most of those up, I
think.
Thanks!
Rusty.
--
Anyone who quotes me in their signature is an idiot -- Rusty Russell
next prev parent reply other threads:[~2004-10-21 0:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-20 7:50 Rusty Russell
2004-10-20 11:23 ` Takashi Iwai
2004-10-21 0:52 ` Rusty Russell [this message]
2004-10-21 9:25 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1098319932.10571.157.camel@localhost.localdomain \
--to=rusty@rustcorp.com.au \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome