From: Scott Feldman <sfeldma@pobox.com>
To: Hanna Linder <hannal@us.ibm.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
kernel-janitors <kernel-janitors@lists.osdl.org>,
greg@kroah.com, Marcelo Tosatti <marcelo.tosatti@cyclades.com>
Subject: Re: [KJ] [PATCH 2.6] cyclades.c: replace pci_find_device
Date: Sun, 24 Oct 2004 11:46:50 -0700 [thread overview]
Message-ID: <1098643610.4188.6.camel@localhost.localdomain> (raw)
In-Reply-To: <267570000.1098383749@w-hlinder.beaverton.ibm.com>
On Thu, 2004-10-21 at 11:35, Hanna Linder wrote:
> diff -Nrup linux-2.6.9cln/drivers/char/cyclades.c linux-2.6.9patch/drivers/char/cyclades.c
> --- linux-2.6.9cln/drivers/char/cyclades.c 2004-10-18 16:35:53.000000000 -0700
> +++ linux-2.6.9patch/drivers/char/cyclades.c 2004-10-20 15:31:49.803025392 -0700
> @@ -4765,7 +4765,7 @@ cy_detect_pci(void)
> for (i = 0; i < NR_CARDS; i++) {
> /* look for a Cyclades card by vendor and device id */
> while((device_id = cy_pci_dev_id[dev_index]) != 0) {
> - if((pdev = pci_find_device(PCI_VENDOR_ID_CYCLADES,
> + if((pdev = pci_get_device(PCI_VENDOR_ID_CYCLADES,
> device_id, pdev)) == NULL) {
> dev_index++; /* try next device id */
> } else {
If there are NR_CARDS (or more) in the system, this will leave a pdev on
the table. A pci_dev_put after the for-loop should catch it.
-scott
next prev parent reply other threads:[~2004-10-24 18:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-21 18:35 Hanna Linder
2004-10-24 18:46 ` Scott Feldman [this message]
2004-11-05 23:06 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1098643610.4188.6.camel@localhost.localdomain \
--to=sfeldma@pobox.com \
--cc=greg@kroah.com \
--cc=hannal@us.ibm.com \
--cc=kernel-janitors@lists.osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.tosatti@cyclades.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®