From: Darren Hart <dvhltc@us.ibm.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Nick Piggin <piggin@cyberone.com.au>,
lkml <linux-kernel@vger.kernel.org>,
Matt Dobson <colpatch@us.ibm.com>,
Martin J Bligh <mbligh@aracnet.com>,
Rick Lindsley <ricklind@us.ibm.com>
Subject: Re: [patch] scheduler: active_load_balance fixes
Date: Mon, 25 Oct 2004 09:58:29 -0700 [thread overview]
Message-ID: <1098723509.23374.10.camel@farah.beaverton.ibm.com> (raw)
In-Reply-To: <20041024023709.2e99cb6d.akpm@osdl.org>
On Sun, 2004-10-24 at 02:37 -0700, Andrew Morton wrote:
> Nick Piggin <piggin@cyberone.com.au> wrote:
> >
> >
> >
> > Darren Hart wrote:
> >
> > >The following patch against the latest mm fixes several problems with
> > >active_load_balance().
> > >
> > >
> >
> > This seems much better. Andrew can you put this into -mm please.
> >
>
> Whenever we touch the load balancing we get sad little reports about
> performance regressions two months later. How do we gain confidence in
> this change?
>
I did run a kernbench test and forgot to include the results, my
apologies. On a 16 way NUMA the new code was slightly faster. The new
code basically does what I believe the original code was intended to do,
it doesn't take a radically new approach to load balancing. It closes
up some corner cases (like continuing to balance after the runqueue is
empty) and fragile code (like removing the dependency on the order of
the sched_group construction). It also removes some of the artificial
limits imposed by the old code, like always moving tasks to the last CPU
of a completely idle group.
I will run some more tests on this code today to improve our confidence.
It would help if others could do the same, particularly those who have
experience balancing problems in the past.
Thanks,
--
Darren Hart
IBM, Linux Technology Center
503 578 3185
dvhltc@us.ibm.com
next prev parent reply other threads:[~2004-10-25 17:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-22 23:36 Darren Hart
2004-10-23 5:30 ` Nick Piggin
2004-10-24 9:37 ` Andrew Morton
2004-10-25 16:58 ` Darren Hart [this message]
2004-10-25 22:37 ` Darren Hart
2004-10-23 10:20 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1098723509.23374.10.camel@farah.beaverton.ibm.com \
--to=dvhltc@us.ibm.com \
--cc=akpm@osdl.org \
--cc=colpatch@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mbligh@aracnet.com \
--cc=piggin@cyberone.com.au \
--cc=ricklind@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®