From: Arjan van de Ven <arjan@infradead.org>
To: Lee Revell <rlrevell@joe-job.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Werner Almesberger <wa@almesberger.net>,
hch@lst.de, davem@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] remove dead tcp exports
Date: Tue, 26 Oct 2004 10:40:51 +0200 [thread overview]
Message-ID: <1098780051.2789.17.camel@laptop.fenrus.org> (raw)
In-Reply-To: <1098765665.9404.5.camel@krustophenia.net>
On Tue, 2004-10-26 at 00:41 -0400, Lee Revell wrote:
> Is this really a compelling reason to remove them? For example ALSA
> provides an API for driver writers, just because a certain function
> happens not to be used by any does not mean is never will be or that it
> should not.
sometimes such "spurious" exports still make sense. Most of the time
they don't, and during these cleanups we've found several functions for
which the only "user" was the export, eg entirely dead code.
Also nobody in the entire tree using a part of the API is a pretty good
sign that the API isn't good or even supposed to be used. (again,
exceptions possible, which is why cleaning this stuff is manual work and
not a script to just nuke it all)
--
next prev parent reply other threads:[~2004-10-26 8:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-24 13:43 Christoph Hellwig
2004-10-26 3:07 ` Werner Almesberger
2004-10-26 3:41 ` David S. Miller
2004-10-26 3:55 ` Werner Almesberger
2004-10-26 4:41 ` Lee Revell
2004-10-26 4:52 ` David S. Miller
2004-10-26 5:43 ` Lee Revell
2004-10-26 8:40 ` Arjan van de Ven [this message]
2004-10-26 9:36 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1098780051.2789.17.camel@laptop.fenrus.org \
--to=arjan@infradead.org \
--cc=davem@davemloft.net \
--cc=davem@redhat.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rlrevell@joe-job.com \
--cc=wa@almesberger.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®