From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 782FDC2BBD0 for ; Tue, 8 Sep 2020 03:34:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5162F2075A for ; Tue, 8 Sep 2020 03:34:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728452AbgIHDex (ORCPT ); Mon, 7 Sep 2020 23:34:53 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:55186 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728327AbgIHDew (ORCPT ); Mon, 7 Sep 2020 23:34:52 -0400 Received: from DGGEMS403-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id E7AD9E161FE542E2FA04; Tue, 8 Sep 2020 11:34:49 +0800 (CST) Received: from [127.0.0.1] (10.174.177.253) by DGGEMS403-HUB.china.huawei.com (10.3.19.203) with Microsoft SMTP Server id 14.3.487.0; Tue, 8 Sep 2020 11:34:48 +0800 Subject: Re: [PATCH 1/1] watchdog: remove unneeded inclusion of To: Guenter Roeck , Wim Van Sebroeck , Peter Zijlstra , Ingo Molnar , linux-watchdog , linux-kernel References: <20200827062154.1847-1-thunder.leizhen@huawei.com> <55ad40ff-dcc1-5051-65d2-24201c471a8f@roeck-us.net> <18762ecb-9b47-18ed-6fbf-7cb4ee561a10@roeck-us.net> From: "Leizhen (ThunderTown)" Message-ID: <1098f1d5-0c36-d5b4-741a-4f2f6f42b428@huawei.com> Date: Tue, 8 Sep 2020 11:34:47 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <18762ecb-9b47-18ed-6fbf-7cb4ee561a10@roeck-us.net> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.253] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/9/8 10:40, Guenter Roeck wrote: > On 9/7/20 12:50 AM, Leizhen (ThunderTown) wrote: >> Hi, Wim Van Sebroeck, Guenter Roeck: >> What's your opinion? Guenter Roeck given "Reviewed-by" two weeks ago. >> > > The patch is in my watchdog-next branch, and Wim usually picks it up > from there. Oh, thanks. > > Guenter > >> >> On 2020/8/27 21:40, Guenter Roeck wrote: >>> On 8/26/20 11:21 PM, Zhen Lei wrote: >>>> There has been no reference to "struct sched_param" since >>>> commit 94beddacb53c ("sched,watchdog: Convert to sched_set_fifo()"), so >>>> there's no need to include any more, delete >>>> it. >>>> >>>> Signed-off-by: Zhen Lei >>> >>> Reviewed-by: Guenter Roeck >>> >>>> --- >>>> drivers/watchdog/watchdog_dev.c | 2 -- >>>> 1 file changed, 2 deletions(-) >>>> >>>> diff --git a/drivers/watchdog/watchdog_dev.c b/drivers/watchdog/watchdog_dev.c >>>> index 6798addabd5a067..0f18fa2433310b0 100644 >>>> --- a/drivers/watchdog/watchdog_dev.c >>>> +++ b/drivers/watchdog/watchdog_dev.c >>>> @@ -43,8 +43,6 @@ >>>> #include /* For watchdog specific items */ >>>> #include /* For copy_to_user/put_user/... */ >>>> >>>> -#include /* For struct sched_param */ >>>> - >>>> #include "watchdog_core.h" >>>> #include "watchdog_pretimeout.h" >>>> >>>> >>> >>> >>> >> > > >