From: David Dillow <dave@thedillows.org>
To: Adrian Bunk <bunk@stusta.de>
Cc: Jeff Garzik <jgarzik@pobox.com>,
linux-net@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] net/typhoon.c: remove an unused function
Date: Thu, 28 Oct 2004 20:08:39 -0400 [thread overview]
Message-ID: <1099008519.8952.26.camel@ori.thedillows.org> (raw)
In-Reply-To: <20041028230629.GY3207@stusta.de>
On Fri, 2004-10-29 at 01:06 +0200, Adrian Bunk wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> The patch below removes an unused function from drivers/net/typhoon.c
NAK -- I'd prefer to make it be used, which was the reason it was there
in the first place... not sure why it wasn't...
===== drivers/net/typhoon.c 1.25 vs edited =====
--- 1.25/drivers/net/typhoon.c 2004-10-21 18:42:58 -04:00
+++ edited/drivers/net/typhoon.c 2004-10-28 20:06:45 -04:00
@@ -1687,8 +1687,7 @@
skb = rxb->skb;
dma_addr = rxb->dma_addr;
- rxaddr += sizeof(struct rx_desc);
- rxaddr %= RX_ENTRIES * sizeof(struct rx_desc);
+ typhoon_inc_rx_index(&rxaddr, 1);
if(rx->flags & TYPHOON_RX_ERROR) {
typhoon_recycle_rx_skb(tp, idx);
prev parent reply other threads:[~2004-10-29 0:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-28 23:06 Adrian Bunk
2004-10-29 0:08 ` David Dillow [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1099008519.8952.26.camel@ori.thedillows.org \
--to=dave@thedillows.org \
--cc=bunk@stusta.de \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®