From: Arjan van de Ven <arjan@infradead.org>
To: David Brownell <david-b@pacbell.net>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Greg KH <greg@kroah.com>,
Linux Kernel list <linux-kernel@vger.kernel.org>,
Paul Mackerras <paulus@samba.org>, Andrew Morton <akpm@osdl.org>
Subject: Re: PCI changes kill USB PM
Date: Sat, 30 Oct 2004 19:52:33 +0200 [thread overview]
Message-ID: <1099158753.3883.6.camel@laptop.fenrus.org> (raw)
In-Reply-To: <200410301044.25476.david-b@pacbell.net>
On Sat, 2004-10-30 at 10:44 -0700, David Brownell wrote:
> Where "now" is "after a change from Arjan in May";
> recent changes made it a more significant problem.
>
> I agree with the guts of your patch -- adding the
> missing "else" in:
>
> if (pci_driver && pci_driver->suspend)
> pci_driver->suspend(pdev, state);
> else
> pci_save_state(pdev);
>
> That makes Arjan's patch only affect PCI drivers
> which don't know how to suspend/resume themselves;
> that's all his patch was supposed to affect.
well the idea back then was to just always save so that drivers could be lazy and only provide a specialized restore. However I agree with this change now that the API changed where regular state saves use the same storage area.
prev parent reply other threads:[~2004-10-30 17:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-30 0:14 Benjamin Herrenschmidt
2004-10-30 17:44 ` David Brownell
2004-10-30 17:52 ` Arjan van de Ven [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1099158753.3883.6.camel@laptop.fenrus.org \
--to=arjan@infradead.org \
--cc=akpm@osdl.org \
--cc=benh@kernel.crashing.org \
--cc=david-b@pacbell.net \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®