From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753077AbbGNIqt (ORCPT ); Tue, 14 Jul 2015 04:46:49 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:56321 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751694AbbGNIqp (ORCPT ); Tue, 14 Jul 2015 04:46:45 -0400 X-AuditID: cbfee691-f79ca6d00000456a-bd-55a4cc73af9b Date: Tue, 14 Jul 2015 08:46:43 +0000 (GMT) From: Rahul Jain Subject: [PATCH v2] cfg80211-wext: deleting dead code To: =?windows-1252?Q?Rafa=3F_Mi=3Fecki?= Cc: David Miller , Johannes Berg , Network Development , Linux Kernel Mailing List , "linux-wireless@vger.kernel.org" , Nitin Jhanwar , HEMANSHU SRIVASTAVA , Amit Khatri Reply-to: rahul.jain@samsung.com MIME-version: 1.0 X-MTR: 20150714084544398@rahul.jain Msgkey: 20150714084544398@rahul.jain X-EPLocale: en_US.windows-1252 X-Priority: 3 X-EPWebmail-Msg-Type: personal X-EPWebmail-Reply-Demand: 0 X-EPApproval-Locale: X-EPHeader: ML X-MLAttribute: X-RootMTR: 20150714084544398@rahul.jain X-ParentMTR: X-ArchiveUser: X-CPGSPASS: N X-ConfirmMail: N,general Content-type: text/plain; charset=windows-1252 MIME-version: 1.0 Message-id: <10994553.722921436863601814.JavaMail.weblogic@ep2mlwas06c> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrEIsWRmVeSWpSXmKPExsWyRsSkWrfkzJJQg3PlFpd3zWFzYPT4vEku gDGKyyYlNSezLLVI3y6BK6Pj9FLWgkWCFZ8aWBsYnwh0MXJyCAmoSuxZupQZxJYQMJG4/3Q7 lC0mceHeerYuRi6gmqWMEve+n2XtYuQAK9r01hUiPodR4ljDWkaQBhagQS/ezmACsdkEtCQe 3W4Fs4UFTCXWPvnKDmKLCNhKXJjwjx2kmVlgArPEuQ8zWSGuUJDYfP87G4jNKyAocXLmExaI K5Qlrt24wQiymFdARWL1MWWIsJzEkqmXmSBsXokZ7U9ZYOLTvq6BekBa4vysDYwwzyz+/hgq zi9x7PYOqF4BialnDkLVaEj0zv0BZfNJrFn4lgWmftep5cwwu+5vmQvVKyGxteUJ2PnMAooS U7ofskPYBhJHFs1hRfcKr4C7xJxTrawQvRM5JGY+tZ7AqDQLSdksJKNmIRmFrGYBI8sqRtHU guSC4qT0IlO94sTc4tK8dL3k/NxNjMCkcPrfs4k7GO8fsD7EKMDBqMTD+9J6SagQa2JZcWXu IUZTYDRNZJYSTc4Hpp68knhDYzMjC1MTU2Mjc0szJXFeHemfwUIC6YklqdmpqQWpRfFFpTmp xYcYmTg4pRoYDzwoPqVqE9kTcG/isTgvrzcHBJZPag3trbi7P7739kWm5+J77AN3u09XjtAU uXNBLC3U9ryKyL43bAkpvU08lnpGs782/NT892bhu8t1M2WuFcX7vrJuFNGbf2Xh0n97Jkw8 /M5d11C6dfpz7yk7rucVsM3La7715sBtFf3vZ4ru8dsppF16q8RSnJFoqMVcVJwIAK2hsUQF AwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrKKsWRmVeSWpSXmKPExsVy+t/tPt3iM0tCDfY0WFhc3jWHzYHR4/Mm uQDGqDSbjNTElNQihdS85PyUzLx0WyXv4HjneFMzA0NdQ0sLcyWFvMTcVFslF58AXbfMHKCh SgpliTmlQKGAxOJiJX07m6L80pJUhYz84hJbpWhDcyM9IwM9UyM9Q9NYK0MDAyNToJqEtIyO 00tZCxYJVnxqYG1gfCLQxcjJISSgKrFn6VLmLkYODgkBE4lNb11BwhICYhIX7q1n62LkAiqZ wyhxrGEtI0iCBaj+xdsZTCA2m4CWxKPbrWC2sICpxNonX9lBbBEBW4kLE/6xgzQzC0xgljj3 YSYrxDIFic33v7OB2LwCghInZz5hgdimLHHtxg1GkCN4BVQkVh9ThgjLSSyZepkJwuaVmNH+ lAUmPu3rGmYIW1ri/KwNjDBHL/7+GCrOL3Hs9g6oXgGJqWcOQtVoSPTO/QFl80msWfiWBaZ+ 16nlzDC77m+ZC9UrIbG15QnY+cwCihJTuh+yQ9gGEkcWzWFF9wqvgLvEnFOtrBMYZWchSc1C 0j4LSTuymgWMLKsYRVMLkguKk9IrTPSKE3OLS/PS9ZLzczcxgpPQsyU7GBsuWB9iFOBgVOLh fWG9JFSINbGsuDL3EKMEB7OSCK/FRqAQb0piZVVqUX58UWlOavEhRlNgrE1klhJNzgcmyLyS eENjE3NTY1MLA0NzczMlcd7/53JDhATSE0tSs1NTC1KLYPqYODilGhhZ58lo6bk9fuDmLeDZ N5X13Kv4lrU3d0l9dRP+6GY0fa2tZt30+G+nVD6m9k6+VsxT2iTs4bD+ba4er9Lzrr3qF7Xd PLU1Apldl7mVFlTP+9hb7l0ZZSpc2BBu3/NT1v9EnL5316qrE7b0TVNzsN80t2qGcrONwoOp /0N3bV2is7tWe0HXJCWW4oxEQy3mouJEAL7cpapYAwAA DLP-Filter: Pass X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id t6E8kwK8023762 >>From e945737ef2e3a5b7198b9795d6375de85b2fac08 Mon Sep 17 00:00:00 2001 From: Rahul Jain Date: Tue, 14 Jul 2015 14:04:09 +0530 Subject: [PATCH] cfg80211-wext: deleting dead code In func cfg80211_wext_siwretry(), the value of changed is getting modified to non-zero value within if-else condition and it is becoming a non-zero value. So, the condition "if (!changed)" becomes unreachable. Signed-off-by: Rahul Jain Signed-off-by: Amit Khatri --- net/wireless/wext-compat.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/net/wireless/wext-compat.c b/net/wireless/wext-compat.c index fd68283..8de1b64 100644 --- a/net/wireless/wext-compat.c +++ b/net/wireless/wext-compat.c @@ -387,9 +387,6 @@ static int cfg80211_wext_siwretry(struct net_device *dev, changed |= WIPHY_PARAM_RETRY_SHORT; } - if (!changed) - return 0; - err = rdev_set_wiphy_params(rdev, changed); if (err) { wdev->wiphy->retry_short = oshort; -- 1.9.1 ------- Original Message ------- Sender : Rafa? Mi?ecki Date : Jul 14, 2015 01:28 (GMT+05:30) Title : Re: [PATCH] Logically DeadCode On 3 July 2015 at 06:52, Rahul Jain wrote: > From 0c34030166a150d6d9f1ab52e7bb40a5440a68c2 Mon Sep 17 00:00:00 2001 > From: Rahul Jain > Date: Fri, 3 Jul 2015 10:19:12 +0530 > Subject: [PATCH] Logically DeadCode You didn't use any prefix for the commit message, it's unclear (Logically DeadCode what?), no description, you touch two code places at once. Please fix above problems and resend.{.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I