On Fri, 2004-09-17 at 02:50, Len Brown wrote: > On Fri, 2004-09-17 at 01:18, Protasevich, Natalie wrote: > > > On Thursday 16 September 2004 11:14 am, Jesse Barnes wrote: > > > > On Thursday, September 16, 2004 2:40 am, Andrew Morton wrote: > > > > bk-acpi.patch > > > > > > > > Looks like some changes in this patch break sn2. In particular, > > this > > > > hunk in acpi_pci_irq_enable(): > > > > > > > > - return_VALUE(0); > > > > + return_VALUE(-EINVAL); > > > > > I think the patch has pointed out that this routine really should be returning 0 > for success and non zero for failure; and returning dev->irq was > probably a latent bug all along. Jesse, I think this one is correct, please let me know if you have any trouble with it. thanks, -Len