From: Cezary Rojewski <cezary.rojewski@intel.com>
To: <phucduc.bui@gmail.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
<linux-sound@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, Mark Brown <broonie@kernel.org>,
"Matthias Brugger" <matthias.bgg@gmail.com>
Subject: Re: [PATCH 1/3] ASoC: mt6797: fix wrong unwind order and error code in enable_clock
Date: Tue, 18 Aug 2026 12:32:15 +0200 [thread overview]
Message-ID: <109a59a6-0b3b-48af-a274-c6a58e5c7246@intel.com> (raw)
In-Reply-To: <20260817113249.69252-1-phucduc.bui@gmail.com>
On 8/17/2026 1:32 PM, phucduc.bui@gmail.com wrote:
> From: bui duc phuc <phucduc.bui@gmail.com>
>
> The error paths in mt6797_afe_enable_clock() use incorrect goto labels,
> causing clocks that failed to enable to be disabled during cleanup.
>
> Fix the goto labels to only unwind clocks that were successfully
> enabled, and return the actual error code.
>
> Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
Aside from my comment regarding mt2701, this mt6797 series should have
its title updated:
ASoC: mediatek: mt6797:
next prev parent reply other threads:[~2026-08-18 10:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-17 11:32 phucduc.bui
2026-08-17 11:32 ` [PATCH 2/3] ASoC: mt6797: Use dev_err_probe() for error handling phucduc.bui
2026-08-17 11:32 ` [PATCH 3/3] ASoC: mt6797: Drop redundant probe error messages phucduc.bui
2026-08-18 10:32 ` Cezary Rojewski [this message]
2026-08-18 11:05 ` [PATCH 1/3] ASoC: mt6797: fix wrong unwind order and error code in enable_clock Bui Duc Phuc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=109a59a6-0b3b-48af-a274-c6a58e5c7246@intel.com \
--to=cezary.rojewski@intel.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-sound@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=perex@perex.cz \
--cc=phucduc.bui@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®