From: Andrzej Hajda <a.hajda@samsung.com>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>,
inki.dae@samsung.com, jy0922.shim@samsung.com,
sw0312.kim@samsung.com, kyungmin.park@samsung.com,
airlied@linux.ie, kgene@kernel.org, krzk@kernel.org,
javier@osg.samsung.com
Cc: dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm: exynos: constify mixer_match_types and *_mxr_drv_data.
Date: Mon, 19 Jun 2017 12:37:35 +0200 [thread overview]
Message-ID: <109c96fc-5d91-f88e-55d3-927dfe5cfba1@samsung.com> (raw)
In-Reply-To: <28c361b34389bfc40fbca6250f6ff24f5f7afe97.1497866987.git.arvind.yadav.cs@gmail.com>
On 19.06.2017 12:12, Arvind Yadav wrote:
> File size before:
> text data bss dec hex filename
> 9983 1424 0 11407 2c8f drivers/gpu/drm/exynos/exynos_mixer.o
>
> File size after constify:
> text data bss dec hex filename
> 11231 176 0 11407 2c8f drivers/gpu/drm/exynos/exynos_mixer.o
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>
--
Regards
Andrzej
> ---
> drivers/gpu/drm/exynos/exynos_mixer.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c b/drivers/gpu/drm/exynos/exynos_mixer.c
> index 25edb63..778cae2 100644
> --- a/drivers/gpu/drm/exynos/exynos_mixer.c
> +++ b/drivers/gpu/drm/exynos/exynos_mixer.c
> @@ -1097,28 +1097,28 @@ static int mixer_atomic_check(struct exynos_drm_crtc *crtc,
> .atomic_check = mixer_atomic_check,
> };
>
> -static struct mixer_drv_data exynos5420_mxr_drv_data = {
> +static const struct mixer_drv_data exynos5420_mxr_drv_data = {
> .version = MXR_VER_128_0_0_184,
> .is_vp_enabled = 0,
> };
>
> -static struct mixer_drv_data exynos5250_mxr_drv_data = {
> +static const struct mixer_drv_data exynos5250_mxr_drv_data = {
> .version = MXR_VER_16_0_33_0,
> .is_vp_enabled = 0,
> };
>
> -static struct mixer_drv_data exynos4212_mxr_drv_data = {
> +static const struct mixer_drv_data exynos4212_mxr_drv_data = {
> .version = MXR_VER_0_0_0_16,
> .is_vp_enabled = 1,
> };
>
> -static struct mixer_drv_data exynos4210_mxr_drv_data = {
> +static const struct mixer_drv_data exynos4210_mxr_drv_data = {
> .version = MXR_VER_0_0_0_16,
> .is_vp_enabled = 1,
> .has_sclk = 1,
> };
>
> -static struct of_device_id mixer_match_types[] = {
> +static const struct of_device_id mixer_match_types[] = {
> {
> .compatible = "samsung,exynos4210-mixer",
> .data = &exynos4210_mxr_drv_data,
prev parent reply other threads:[~2017-06-19 10:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170619101327epcas2p27bb709ee46519fade54663884ef74c88@epcas2p2.samsung.com>
2017-06-19 10:12 ` Arvind Yadav
2017-06-19 10:37 ` Andrzej Hajda [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=109c96fc-5d91-f88e-55d3-927dfe5cfba1@samsung.com \
--to=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=arvind.yadav.cs@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=inki.dae@samsung.com \
--cc=javier@osg.samsung.com \
--cc=jy0922.shim@samsung.com \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=sw0312.kim@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®