From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-172.mta1.migadu.com (out-172.mta1.migadu.com [95.215.58.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5AC2530F7F2 for ; Wed, 3 Jun 2026 02:40:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780454412; cv=none; b=icXoyLMbeX3T9wYBE3qXpdfBr/1fHZbQE+5GyzUtavOyDJ8mPJNcJhZTeM9UjhU0Ec0OzcbTaw+edbvqJTbL7cFEaH3fYpSb+4pEwDTTHdnBoDMweV60oXsw9NxCkNzDrlL5f2WEGE8MP2MrPXL3BE1RwnwHh6bKIBj//vlewQc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780454412; c=relaxed/simple; bh=7b4GB088fxVFUSs//z0e8F0RMQl1VndkWvgoQRJMSFI=; h=Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc: Message-Id:References:To; b=qPOPvW27XHEOLp/56RzMYlP/cceTzFFoIQGoS6PTmk9b66DcvXW3NnJpbDJ3kTBtngbWCKJnxuKhd9g8VP0jMQ9L8vOBfXlD1PSwmm/JOqw9xCo+vsUs8mjYgFSa1Clen74UkStVgbIBU2AIhXD7IuEf/KS/BUlPbLPUlZXh6Ks= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=a6OO/AGV; arc=none smtp.client-ip=95.215.58.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="a6OO/AGV" Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1780454408; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=enhp+3s0SIGEOwjQc/7W6s5wIzCQbFdyWa31w7PMhyM=; b=a6OO/AGVjZPTkYLmFE58mUZkc+Ig9OvucaVesgXboaIsfd35hyTrwEOUiKCMdq62BTHjWY 3iDA8+TOhj7GAKI9lEBKJK0ZAnOuZOAJh+A43sHVWZsP4eRe4lyDV6hA2e/VlitznVZPoQ w1ZVN5buyzqpE2WMljQJpn7BDAJVmsc= Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.600.51.1.1\)) Subject: Re: [PATCH v3 19/19] mm/mm_init: Fold __init_page_from_nid() into __init_deferred_page() X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: <178041489408.457517.2991925440539441241.b4-review@b4> Date: Wed, 3 Jun 2026 10:39:20 +0800 Cc: Muchun Song , Oscar Salvador , David Hildenbrand , Andrew Morton , Madhavan Srinivasan , Michael Ellerman , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Nicholas Piggin , "Christophe Leroy (CS GROUP)" , "Ritesh Harjani (IBM)" , "Aneesh Kumar K.V" , linuxppc-dev@lists.ozlabs.org Content-Transfer-Encoding: quoted-printable Message-Id: <10D5F5E9-889C-4B4D-B104-A1579A771F45@linux.dev> References: <20260602101039.1867613-1-songmuchun@bytedance.com> <20260602101039.1867613-20-songmuchun@bytedance.com> <178041489408.457517.2991925440539441241.b4-review@b4> To: Mike Rapoport X-Migadu-Flow: FLOW_OUT > On Jun 2, 2026, at 23:41, Mike Rapoport wrote: >=20 > On Tue, 02 Jun 2026 18:10:39 +0800, Muchun Song = wrote: >> diff --git a/mm/mm_init.c b/mm/mm_init.c >> index 41b83dd18c01..f1bbf3b9a321 100644 >> --- a/mm/mm_init.c >> +++ b/mm/mm_init.c >> @@ -771,10 +746,27 @@ defer_init(int nid, unsigned long pfn, unsigned = long end_pfn) >>=20 >> static void __meminit __init_deferred_page(unsigned long pfn, int = nid) >> { >> + pg_data_t *pgdat; >> + int zid; >> + >> if (early_page_initialised(pfn, nid)) >> return; >>=20 >> - __init_page_from_nid(pfn, nid); >> + pgdat =3D NODE_DATA(nid); >=20 > Nit: we can initialize pgdat at declaration line, other than that Yes, will do next version. >=20 > Reviewed-by: Mike Rapoport (Microsoft) Thanks. >=20 > --=20 > Sincerely yours, > Mike. >=20