mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Luck, Tony" <tony.luck@intel.com>
To: Jia Zhang <qianyue.zj@alibaba-inc.com>
Cc: "bp@alien8.de" <bp@alien8.de>,
	"tglx@linutronix.de" <tglx@linutronix.de>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"hpa@zytor.com" <hpa@zytor.com>,
	"x86@kernel.org" <x86@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4] x86/microcode/intel: Blacklist the specific BDW-EP for late loading
Date: Wed, 27 Dec 2017 04:52:37 +0000	[thread overview]
Message-ID: <10DA9229-676A-4780-AD11-120FA7855274@intel.com> (raw)
In-Reply-To: <1514292147-101928-1-git-send-email-qianyue.zj@alibaba-inc.com>

When all the patch issues are ironed out consider this 

Acked-by: Tony Luck <tony.luck@intel.com>

I was planning to hunt down the erratum when I got back from vacation in the new year.

Sent from my iPhone

> On Dec 26, 2017, at 04:42, Jia Zhang <qianyue.zj@alibaba-inc.com> wrote:
> 
> Instead of blacklisting all types of Broadwell processor when running
> a late loading, only BDW-EP (signature 0x406f1, aka family 6, model 79,
> stepping 1) with the microcode version less than 0x0b000021 needs to
> be blacklisted.
> 
> The erratum is documented in the the public documentation #334165 (See
> the item BDF90 for details).
> 
> Signed-off-by: Jia Zhang <qianyue.zj@alibaba-inc.com>
> ---
> arch/x86/kernel/cpu/microcode/intel.c | 12 ++++++++++--
> 1 file changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/kernel/cpu/microcode/intel.c b/arch/x86/kernel/cpu/microcode/intel.c
> index 8ccdca6..79cad85 100644
> --- a/arch/x86/kernel/cpu/microcode/intel.c
> +++ b/arch/x86/kernel/cpu/microcode/intel.c
> @@ -910,8 +910,16 @@ static bool is_blacklisted(unsigned int cpu)
> {
>    struct cpuinfo_x86 *c = &cpu_data(cpu);
> 
> -    if (c->x86 == 6 && c->x86_model == INTEL_FAM6_BROADWELL_X) {
> -        pr_err_once("late loading on model 79 is disabled.\n");
> +    /*
> +     * The Broadwell-EP processor with the microcode version less
> +     * then 0x0b000021 may result in system hang when running a late
> +     * loading. This behavior is documented in item BDF90, #334165
> +     * (Intel Xeon Processor E7-8800/4800 v4 Product Family).
> +     */
> +    if (c->x86 == 6 && c->x86_model == INTEL_FAM6_BROADWELL_X &&
> +        c->x86_mask == 0x01 && c->microcode < 0x0b000021) {
> +        pr_err_once("late loading on cpu (sig 0x406f1) is disabled "
> +                "due to erratum causing system hang.\n");
>        return true;
>    }
> 
> -- 
> 1.8.3.1
> 

  reply	other threads:[~2017-12-27  4:52 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-26 12:42 Jia Zhang
2017-12-27  4:52 ` Luck, Tony [this message]
2017-12-28 12:24 ` Ingo Molnar
2017-12-28 13:23   ` Jia Zhang
2017-12-29 12:48     ` Ingo Molnar
2017-12-29 13:17       ` Jia Zhang
2017-12-29 13:44         ` Borislav Petkov
2017-12-29 14:12           ` Jia Zhang
2017-12-29 14:40             ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=10DA9229-676A-4780-AD11-120FA7855274@intel.com \
    --to=tony.luck@intel.com \
    --cc=bp@alien8.de \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=qianyue.zj@alibaba-inc.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®