mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vincenzo Frascino <vincenzo.frascino@arm.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>,
	Linus Walleij <linusw@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Liviu Dudau <liviu.dudau@arm.com>,
	Sudeep Holla <sudeep.holla@arm.com>,
	Lorenzo Pieralisi <lpieralisi@kernel.org>,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] arm64: dts: arm: Use hyphen in node names
Date: Wed, 24 Dec 2025 11:58:44 +0000	[thread overview]
Message-ID: <10a089d2-4823-4406-b1a9-d38f05ba0760@arm.com> (raw)
In-Reply-To: <20251223152457.155392-3-krzysztof.kozlowski@oss.qualcomm.com>



On 23/12/2025 15:24, Krzysztof Kozlowski wrote:
> DTS coding style prefers hyphens instead of underscores in the node
> names.  Change should be safe, because node names are not considered an
> ABI.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
>

Acked-by: Vincenzo Frascino <vincenzo.frascino@arm.com>

> ---
> 
> Patches done with sed, verified with comparing unflattened DTB and
> dtx_diff.
> ---
>  arch/arm64/boot/dts/arm/morello-fvp.dts | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/arm/morello-fvp.dts b/arch/arm64/boot/dts/arm/morello-fvp.dts
> index 2072c0b72325..4a3f217555f7 100644
> --- a/arch/arm64/boot/dts/arm/morello-fvp.dts
> +++ b/arch/arm64/boot/dts/arm/morello-fvp.dts
> @@ -25,25 +25,25 @@ bp_refclock24mhz: clock-24000000 {
>  		clock-output-names = "bp:clock24mhz";
>  	};
>  
> -	block_0: virtio_block@1c170000 {
> +	block_0: virtio-block@1c170000 {
>  		compatible = "virtio,mmio";
>  		reg = <0x0 0x1c170000 0x0 0x200>;
>  		interrupts = <GIC_SPI 96 IRQ_TYPE_LEVEL_HIGH>;
>  	};
>  
> -	net_0: virtio_net@1c180000 {
> +	net_0: virtio-net@1c180000 {
>  		compatible = "virtio,mmio";
>  		reg = <0x0 0x1c180000 0x0 0x200>;
>  		interrupts = <GIC_SPI 102 IRQ_TYPE_LEVEL_HIGH>;
>  	};
>  
> -	rng_0: virtio_rng@1c190000 {
> +	rng_0: virtio-rng@1c190000 {
>  		compatible = "virtio,mmio";
>  		reg = <0x0 0x1c190000 0x0 0x200>;
>  		interrupts = <GIC_SPI 101 IRQ_TYPE_LEVEL_HIGH>;
>  	};
>  
> -	p9_0: virtio_p9@1c1a0000 {
> +	p9_0: virtio-p9@1c1a0000 {
>  		compatible = "virtio,mmio";
>  		reg = <0x0 0x1c1a0000 0x0 0x200>;
>  		interrupts = <GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH>;

-- 
Regards,
Vincenzo


  parent reply	other threads:[~2025-12-24 11:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-23 15:24 Krzysztof Kozlowski
2025-12-23 15:24 ` [PATCH 2/2] arm64: dts: arm: Use lowercase hex Krzysztof Kozlowski
2025-12-24 11:59   ` Vincenzo Frascino
2026-01-01 17:15   ` Sudeep Holla
2026-02-24 11:54     ` Krzysztof Kozlowski
2026-02-24 13:47       ` Linus Walleij
2025-12-24 11:58 ` Vincenzo Frascino [this message]
2026-01-01 17:52 ` [PATCH 1/2] arm64: dts: arm: Use hyphen in node names Sudeep Holla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=10a089d2-4823-4406-b1a9-d38f05ba0760@arm.com \
    --to=vincenzo.frascino@arm.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzysztof.kozlowski@oss.qualcomm.com \
    --cc=linusw@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liviu.dudau@arm.com \
    --cc=lpieralisi@kernel.org \
    --cc=robh@kernel.org \
    --cc=sudeep.holla@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®