From: Paolo Abeni <pabeni@redhat.com>
To: Yajun Deng <yajun.deng@linux.dev>,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, horms@kernel.org
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2] net: sysfs: Implement is_visible for phys_(port_id, port_name, switch_id)
Date: Tue, 27 May 2025 08:08:51 +0200 [thread overview]
Message-ID: <10a15ca4-ff93-4e62-9953-cbd3ba2c3f53@redhat.com> (raw)
In-Reply-To: <20250521140824.3523-1-yajun.deng@linux.dev>
On 5/21/25 4:08 PM, Yajun Deng wrote:
> phys_port_id_show, phys_port_name_show and phys_switch_id_show would
> return -EOPNOTSUPP if the netdev didn't implement the corresponding
> method.
>
> There is no point in creating these files if they are unsupported.
>
> Put these attributes in netdev_phys_group and implement the is_visible
> method. make phys_(port_id, port_name, switch_id) invisible if the netdev
> dosen't implement the corresponding method.
>
> Signed-off-by: Yajun Deng <yajun.deng@linux.dev>
I fear that some orchestration infra depends on the files existence -
i.e. scripts don't tolerate the files absence, deal only with I/O errors
after open.
It feel a bit too dangerous to merge a change that could break
user-space this late. Let's defer it to the beginning of the next cycle.
Paolo
next prev parent reply other threads:[~2025-05-27 6:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-21 14:08 Yajun Deng
2025-05-22 13:52 ` Simon Horman
2025-05-27 6:08 ` Paolo Abeni [this message]
2025-06-12 8:51 ` Yajun Deng
2025-06-12 9:28 ` Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10a15ca4-ff93-4e62-9953-cbd3ba2c3f53@redhat.com \
--to=pabeni@redhat.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yajun.deng@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®