From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-171.mta1.migadu.com (out-171.mta1.migadu.com [95.215.58.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 83DA51DF75D for ; Thu, 20 Feb 2025 15:56:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740066966; cv=none; b=aLM9Wn3OAl8i5QiM4xwK7ZNWnur3e5WOrhKDkiwICtHMVCA2YrcK1QvnabKTnd3Y8HhEKgzwcqpNh0ARfUU4uuhKy1/uXmiDdwJ71ZkeeB1c3bJ62mOrLUTGJYK1KwUZFxvqNhZsHrcKaXkutUmSIGtH5M3iN7Se+o3wkJzywco= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740066966; c=relaxed/simple; bh=nhYN2GbUzsXa4cjLPXbV4eUQPu/IKKaTnKG8XoaoATY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=iPOVTcma9Zzh++HCXzFfx/8jiOUPP6f30TU0kF6lR2okijfr3RO/EDuq2+UHw2DHR1STQXrb2zQAIWw3IeQnLekyn0+IAQLCmAWlqWdVVDjvE8OLvVQsIERiw90jQUShWgoQe5cN8yEZ4IHibbZVhYAiNjgUnMAQxe/G7nzkCX4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=thybdZfO; arc=none smtp.client-ip=95.215.58.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="thybdZfO" Message-ID: <10a50a6c-a6be-4723-80b3-62119f667977@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1740066960; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Up76eQNOfacddlQs6IG6ddJKmIeZ0tEzsFl4x96svGY=; b=thybdZfO1kWLW7dneUHxK3W2lJuskGvpikEy0T7i1mCJVlui2m7i/emTde1TfrM5woF6Nn e9agtZ9W5YY941OvQTRP/7VFbwclmcLpMA8eLehw253qrTKxGEb1yz2c7g8QbgqgYhjkyj Cs5Pj6HLKRHHyipCxzgd+B2AT1pxqHo= Date: Thu, 20 Feb 2025 10:55:45 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH net-next] net: cadence: macb: Implement BQL To: Jakub Kicinski Cc: Nicolas Ferre , Claudiu Beznea , netdev@vger.kernel.org, "David S . Miller" , Andrew Lunn , linux-kernel@vger.kernel.org, Paolo Abeni , Eric Dumazet References: <20250214211643.2617340-1-sean.anderson@linux.dev> <20250218175700.4493dc49@kernel.org> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Sean Anderson In-Reply-To: <20250218175700.4493dc49@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 2/18/25 20:57, Jakub Kicinski wrote: > On Fri, 14 Feb 2025 16:16:43 -0500 Sean Anderson wrote: >> diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c >> index 48496209fb16..63c65b4bb348 100644 >> --- a/drivers/net/ethernet/cadence/macb_main.c >> +++ b/drivers/net/ethernet/cadence/macb_main.c >> @@ -1081,6 +1081,9 @@ static void macb_tx_error_task(struct work_struct *work) >> tx_error_task); >> bool halt_timeout = false; >> struct macb *bp = queue->bp; >> + u32 queue_index = queue - bp->queues; > > nit: breaking reverse xmas tree here It has to happen here since bp isn't available earlier. >> + u32 packets = 0; >> + u32 bytes = 0; >> struct macb_tx_skb *tx_skb; >> struct macb_dma_desc *desc; >> struct sk_buff *skb; > > >> @@ -3019,6 +3033,7 @@ static int macb_close(struct net_device *dev) >> netif_tx_stop_all_queues(dev); >> >> for (q = 0, queue = bp->queues; q < bp->num_queues; ++q, ++queue) { >> + netdev_tx_reset_queue(netdev_get_tx_queue(dev, q)); >> napi_disable(&queue->napi_rx); >> napi_disable(&queue->napi_tx); > > I think you should reset after napi_disable()? > Lest NAPI runs after the reset and tries to complete on an empty queue.. OK. --Sean