From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794048422; b=AWSvC24TJZ4rBXLKs5f/Azq/g4ht4ZQQKvhQYigHXwrixiEUwUif55jDQNY1kzs27wO8 1hmbxtwT0knwEAtzwGhrq+UwSrs2VbfBALBqtDOELCgmsZrSd7QHWisaTtJmL4dhi+qEI O1Lpa9QMULAWwg7uGhVqeNKEjLcM3si3p1MreCrhj+077EOYzQrzX78QNOv42DvOQUFFu Bg6EehOFsfqKJznWr8QNYL5oQsmhQ0cqOw1awMH+QGAd/CTYFyiaYacQ+WL244BkDbcy6 Vx3kF6kpUfJYK1dle/CFsIbXVAixZmWaVAORvB+liQyAQUxTShIrK7NiP0yI8RqGx3w== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794048422; h=Received:DKIM-Signature:Message-ID:Date:MIME-Version:User-Agent: Subject:To:Cc:References:From:Content-Language:Autocrypt:In-Reply-To: Content-Type:Content-Transfer-Encoding; bh=j5nV0hNcfCPqw7ejNajVDjDG0qCCWAXLjE0YZdaIMWQ=; b=GnrV+zE+8olKfXhl8c46Fp+1Wx5aBAgCpi2D/q454EhfKQAUa7yTQJPKrncNWNOq+FeJ pqSXB8n4WN2t+ZLKbv7Zhe7rXzC/MmUpffGKAgOeZRvkr4AeVpJ6JaBWaQtORD9L3XkJO PWRx1uufD/vq8Yl4A9F/KoDsB3G2SS1efUJE1cjmsaPXP1WUtu3qL6XpdMz+0m02nvBK6 lj00hu9XwuqvzbVL3VRChoWlqTN3FNOASj/N3CcqosZNz1ymbn1o0vkiwSLrGhnfMdeS0 6tm118UMxWSWeJriI93defyqH2cQ5ncT1UoVrlK7C+OW7hX/Z7iVtDIGJb4aR77GMEg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=HYPP7jGj; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B44D4606A32C for ; Sat, 7 Nov 2026 10:47:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=HYPP7jGj Received: by smtp.kernel.org (Postfix) with ESMTPSA id D726A1F008A1; Sat, 7 Nov 2026 10:46:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794048421; bh=j5nV0hNcfCPqw7ejNajVDjDG0qCCWAXLjE0YZdaIMWQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=HYPP7jGj+iytrbWhImO7gLE9PKhMkW+TNjutaEeEdxOZIrlaDsNHDPSdfBhVz3QEl bEalnXJvDgr57ZmfbdH+ZIpuNA8ZdeIcgubCf9lVDBQOqw46alk5KMbwhKUwkp1Fqm IaentZvJxeU4yKqBxcvN/CsF1in+avenONhz5nMwTZdVEvugsEAG5biE5OqNZNLdsP nuq5I5ZD15xEEahx4nkfmWXO/7WLjACZxzhwajLfvhvJxKibahwi3NkPmCsyfQc/EN Ff+celB9ILJ9YMZdKGcwPne52Jj6hXp5d0lI0Y9fy2kY2nMagOJBxrlWOFV3K9Mh1l sOKQEMAH7NeOw== Message-ID: <10aacc3f-9ac9-413b-9216-ee166b1c6bef@kernel.org> Date: Sat, 7 Nov 2026 11:46:57 +0100 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] extcon: max77843: convert to subsys_platform_driver() To: Brian Masney , Chanwoo Choi , MyungJoo Ham Cc: linux-kernel@vger.kernel.org References: <20261106-extcon-subsys-v1-1-6a781b323d6f@redhat.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGPBBMBCgA5AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJp2mE8AAoJEBuTQ307QWKbeaIP /ihHTkTW4KsN/DQ945JJbyu5tI0J80Wue7QyyLPglyKfhgb5cLLNPpOC8cCIJsc7+W3i2P38 s2c1cOH6CYGE7E9ur3Vfme8NW2S2I/Z8VC7bZnzyS23wT17LrsdS/qCpx4o8U+pt/xdXDKph EGRYrIEmMpUWvyYzyYKGIe25FtaayIIKpq8eZYyFcp2f/sG5IkOW5uZzHPMPdcm87jU7fyuQ rAU2vx9r+ulUfQ/q9Z2roC/ode3l7t2pN7BCBCsUDp6JCrUyZrtT1e7EbA0ZRP3aOBNk2P2E DQOgJGjGdO5Yx2Y9LFtltu6JbsBJHi1syGRX3AtQYOMc4Y1WGoeZJmMlvKj2ZqqXNkcWi2DS IQEWB0uW6CqFsBBIMGDa+6OzdaVO/uAVXWDWml02Men3CILdI1MbVjoh8ECqYUY7OQ+JJvNN vnliuq5WM3Ghd3jg/LZZrxXjdIginRHFQCjIJYLKpLZWm1/iDFedcfzqRNYmTtqscdCNHW41 oT3Z7BmO9xwdjuwBS6nmS6JJwkbf5Ot2QR4pB/DRU7ZwjT1qHe+9r9gF32wXVQatHNGK/VVu sfwOnkdxCWkp/qb2gdQRmZh+SedStWshigH6sNfuHBloF/q+hjMRc8b2m326OZdrbSHwY1Sz vti8Hn7n8NjdHO9LKB7BIdjkA9DA5WsqOuVCzsFNBFVDXDQBEADNkrQYSREUL4D3Gws46JEo Z9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLueMNsWLJBv BaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6eiOMheesVS 5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wAGldWsRxb f3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA6z6lBZn0 WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9YegxWKvX XHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt91pFzBSO IpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gUBLHFTg2h YnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/JoFzZ4B0 p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu4vXVFBYI GmpyNPYzRm0QPwARAQABwsF2BBgBCgAgAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtBYpsFAmna YUkACgkQG5NDfTtBYptX+BAApg32CkxwNucNEi8WfWA8oKkW0y8YDuY6ORMo9FWNGiT/OTy0 vyJrLocrpn86zwfjVp+eCrssPYh8eqJfnWqmYv6ACQtHPYzPZQ3mSo8H97Z01oUxITzCxpXm ZkLgPIqtDPcC2E3dPM/fVxcyowM8XsaMA9wcsaUYrta8toOq2b9tKcjleKMfMrm0gQ9u7wUc QbLkwj6TCLOwucb07GXzLTNF9PZmaDUpKAZjMjmrW+le+SFvQbhamx0rxLWPR0NWntXpbCn+ +ACch03p/JyTBVktxFsFyCt7pTPE1kEaeuXBTe/a2D9iQvRxRW19LvuO2e59/u1wYUiH/orz wbIC2S4dBsPAPihL3ztOU1yE86GPyQtSE0kU+/7snnLt4QGi6PChf3t5gnNjAzjUUovO8rgI c+5yN5heq5loYHgK6OQ9OlHzsPHO9e9MOQcKlFycs1pyijFGzDwdNUm/SchK8iWT2QApTx4A K9bCVaboTA2T77QYkRcRJYSsO1alGX0ome/hMLD1daXlkrNUp1HWa3K4iytLRXjCSIorWiGs n+q3krnpXu3TFkA8qtOFZMdnIiFuiq1yLT8hptsV5xh1TA2nsVvSYiaCr3q4s4BKjS/KrLDb qoxzw8ISjdUp4pA85vb6YLCmb39NgidD+7PmAr65lBNveIFynTgsja1rRQ4= In-Reply-To: <20261106-extcon-subsys-v1-1-6a781b323d6f@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 07/11/2026 02:07, Brian Masney wrote: > Reduce boilerplate code in this driver and convert it over to use > the macro subsys_platform_driver(). > > Note that this driver is configured in the Kconfig to be a tristate, > the driver doesn't have suppress_bind_attrs set, and there is no __exit > function defined. This change will add an __exit function that > unregisters the platform driver. > > Signed-off-by: Brian Masney > --- > drivers/extcon/extcon-max77843.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) I am 99% sure that this driver can function as module platform driver, because it has necessary MODULE_DEVICE_TABLE() and device is not needed for early boot. Nevertheless, this change itself is also correct. Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof