From: Jeremy Linton <jeremy.linton@arm.com>
To: Sudeep Holla <sudeep.holla@arm.com>,
"Rafael J. Wysocki" <rafael@kernel.org>
Cc: ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
Catalin Marinas <catalin.marinas@arm.com>,
Morten Rasmussen <morten.rasmussen@arm.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Hanjun Guo <hanjun.guo@linaro.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Will Deacon <will.deacon@arm.com>
Subject: Re: [PATCH v2 3/3] arm64: disable ACPI PPTT support temporarily
Date: Tue, 5 Jun 2018 11:38:28 -0500 [thread overview]
Message-ID: <10ae59bd-1767-317e-111d-d4d4d71e077a@arm.com> (raw)
In-Reply-To: <a93212e3-7965-9ae2-34b0-407f04590567@arm.com>
Hi,
On 06/05/2018 10:27 AM, Sudeep Holla wrote:
>
>
> On 05/06/18 16:02, Rafael J. Wysocki wrote:
>> On Tue, Jun 5, 2018 at 4:35 PM, Sudeep Holla <sudeep.holla@arm.com> wrote:
>>> Currently, ARM64 doesn't support updating the CPU topology masks on
>>> CPU hotplug operations. ACPI PPTT support rely on that missing feature
>>> which is technically not incorrect. Instead of reverting all the PPTT
>>> support, let's keep it simple and disable ACPI PPTT support on ARM64
>>> for time-being until the topology updates are added for CPU hotplug
>>> operations.
>>
>> When is that going to happen?
>>> Nobody else uses PPTT now.
>>
>
> No we need it on ARM64. I have even the fixes for the original issue
> but it's bit invasive and too late as we are already in the merge
> window. It needs to be tested on NUMA platforms, I have asked for that
> explicitly.
>
So, there is a lot simpler fix for this, and its to remove the numa mask
dependency from the scheduler domain building. That is just a couple
line fix, and it reverts !ACPI to its original behavior, while the ACPI
LLC building will work around the NUMA in package issue that caused
patch 12/12 as the machine in question doesn't have a LLC crossing numa
domains.
prev parent reply other threads:[~2018-06-05 16:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-05 14:35 [PATCH v2 1/3] Revert "arm64: topology: divorce MC scheduling domain from core_siblings" Sudeep Holla
2018-06-05 14:35 ` [PATCH v2 2/3] ACPI / PPTT: fix build when CONFIG_ACPI_PPTT is not enabled Sudeep Holla
2018-06-05 15:00 ` Rafael J. Wysocki
2018-06-05 15:33 ` Sudeep Holla
2018-06-05 16:12 ` Rafael J. Wysocki
2018-06-05 16:18 ` Sudeep Holla
2018-06-05 16:20 ` Rafael J. Wysocki
2018-06-05 17:08 ` Catalin Marinas
2018-06-05 14:35 ` [PATCH v2 3/3] arm64: disable ACPI PPTT support temporarily Sudeep Holla
2018-06-05 15:02 ` Rafael J. Wysocki
2018-06-05 15:27 ` Sudeep Holla
2018-06-05 16:38 ` Jeremy Linton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10ae59bd-1767-317e-111d-d4d4d71e077a@arm.com \
--to=jeremy.linton@arm.com \
--cc=catalin.marinas@arm.com \
--cc=geert@linux-m68k.org \
--cc=hanjun.guo@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=morten.rasmussen@arm.com \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=sudeep.holla@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®