From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Bjorn Helgaas <helgaas@kernel.org>, Johan Hovold <johan@kernel.org>
Cc: "Manivannan Sadhasivam" <mani@kernel.org>,
"Bjorn Andersson" <andersson@kernel.org>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Stanimir Varbanov" <svarbanov@mm-sol.com>,
"Andrew Murray" <amurray@thegoodpenguin.co.uk>,
"Vinod Koul" <vkoul@kernel.org>,
"Marijn Suijten" <marijn.suijten@somainline.org>,
linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] PCI: qcom: Reshuffle reset logic in 2_7_0 .init
Date: Sat, 30 Dec 2023 23:11:21 +0100 [thread overview]
Message-ID: <10b38cb3-cfe0-4fff-8c10-4d2ec98f9dc7@linaro.org> (raw)
In-Reply-To: <20231229154604.GA1577854@bhelgaas>
On 29.12.2023 16:46, Bjorn Helgaas wrote:
> On Fri, Dec 29, 2023 at 03:04:23PM +0100, Johan Hovold wrote:
>> On Wed, Dec 27, 2023 at 11:17:19PM +0100, Konrad Dybcio wrote:
>> ...
>
>> This is arguably a separate change, and not necessarily one that is
>> correct either, so should at least go in a separate patch if it should
>> be done at all.
>
> A nice side effect of splitting might be that it would be a chance to
> put a little more specific information in the subject lines.
> "Reshuffle reset logic" by itself doesn't connect it to a specific
> issue or reason for the change.
Yes, sorry, that's on me.
I've been deep inside this topic recently and many things on the QC
side are quite obvious to me, but I often keep forgetting that I
need to externalize that knowledge in commit messages properly..
Konrad
next prev parent reply other threads:[~2023-12-30 22:11 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-27 22:17 [PATCH 0/4] Qualcomm PCIe RC shutdown & reinit Konrad Dybcio
2023-12-27 22:17 ` [PATCH 1/4] PCI: qcom: Reshuffle reset logic in 2_7_0 .init Konrad Dybcio
2023-12-29 14:04 ` Johan Hovold
2023-12-29 15:01 ` Konrad Dybcio
2023-12-29 15:29 ` Johan Hovold
2023-12-30 1:16 ` Konrad Dybcio
2024-01-01 17:31 ` Manivannan Sadhasivam
2024-01-02 10:17 ` Johan Hovold
2024-01-02 17:03 ` Konrad Dybcio
2024-01-03 10:40 ` Johan Hovold
2024-01-03 12:11 ` Konrad Dybcio
2023-12-29 15:46 ` Bjorn Helgaas
2023-12-30 22:11 ` Konrad Dybcio [this message]
2023-12-27 22:17 ` [PATCH 2/4] PCI: qcom: Cache last icc bandwidth Konrad Dybcio
2023-12-27 22:17 ` [PATCH 3/4] PCI: qcom: Read back PARF_LTSSM register Konrad Dybcio
2024-01-02 17:05 ` Manivannan Sadhasivam
2023-12-27 22:17 ` [PATCH 4/4] PCI: qcom: Implement RC shutdown/power up Konrad Dybcio
2023-12-28 15:12 ` kernel test robot
2023-12-29 3:42 ` kernel test robot
2024-01-02 17:07 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10b38cb3-cfe0-4fff-8c10-4d2ec98f9dc7@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=amurray@thegoodpenguin.co.uk \
--cc=andersson@kernel.org \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=johan@kernel.org \
--cc=kw@linux.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=svarbanov@mm-sol.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®