From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752055AbeB1GbZ (ORCPT ); Wed, 28 Feb 2018 01:31:25 -0500 Received: from mga18.intel.com ([134.134.136.126]:8538 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751818AbeB1GbY (ORCPT ); Wed, 28 Feb 2018 01:31:24 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,404,1515484800"; d="scan'208";a="21630172" Subject: Re: [alsa-devel] [PATCH 0/1] Re: Applied "ASoC: topology: Fix logical inversion in set_link_hw_format()" to the asoc tree To: Kirill Marinushkin , Mark Brown Cc: Pan Xiuli , Liam Girdwood , linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org References: <20180227155758.GD11822@sirena.org.uk> <20180227203317.17274-1-k.marinushkin@gmail.com> From: Pierre-Louis Bossart Message-ID: <10bebc9d-3c16-c301-b71b-87786525da14@linux.intel.com> Date: Tue, 27 Feb 2018 22:31:23 -0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180227203317.17274-1-k.marinushkin@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/27/18 12:33 PM, Kirill Marinushkin wrote: > Hello Mark, Pierre-Louis, Pan, Liam, > > As there are too much open questions regarding the bclk and fsync inversion in > set_link_hw_format(), I would like to suggest the alternative solution. > > This solution will fit both use-cases: > > * existing use-cases (Broadwell, etc.) > * new use-cases (Sound Open Firmware, etc.) > > The solution includes 1 patch for linux + 1 patch for alsa-lib. > I will send them to this mailing thread. That looks acceptable to me, Xiuli can you test with with the matching change in the SOF topology macros (we can keep the 'slave' in M4 files but expand to 'codec_slave' in the .conf to avoid making this exception visible). > > Signed-off-by: Kirill Marinushkin > Cc: Mark Brown > Cc: Pierre-Louis Bossart > Cc: Pan Xiuli > Cc: Liam Girdwood > Cc: linux-kernel@vger.kernel.org > Cc: alsa-devel@alsa-project.org > > Kirill Marinushkin (1): > ASoC: topology: Fix bclk and fsync inversion in set_link_hw_format() > > include/uapi/sound/asoc.h | 16 ++++++++++++++-- > sound/soc/soc-topology.c | 12 +++++++----- > 2 files changed, 21 insertions(+), 7 deletions(-) >