From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752409AbdJSJHS (ORCPT ); Thu, 19 Oct 2017 05:07:18 -0400 Received: from mail-wm0-f46.google.com ([74.125.82.46]:56306 "EHLO mail-wm0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751809AbdJSJHO (ORCPT ); Thu, 19 Oct 2017 05:07:14 -0400 X-Google-Smtp-Source: ABhQp+QAPweWXylQauGluHnjWzmbyVfMOou/ZXHxTazg6e2dVPisoDuFQdpe+RIDKoe75mRabD0AHA== Subject: Re: [PATCH v6 2/5] clocksource: stm32: convert driver to timer_of To: Benjamin Gaignard , Thomas Gleixner Cc: Rob Herring , Mark Rutland , Russell King - ARM Linux , Maxime Coquelin , Alexandre Torgue , Ludovic Barre , Julien Thierry , devicetree@vger.kernel.org, Linux ARM , Linux Kernel Mailing List References: <1508331506-23782-1-git-send-email-benjamin.gaignard@linaro.org> <1508331506-23782-3-git-send-email-benjamin.gaignard@linaro.org> From: Daniel Lezcano Message-ID: <10c85c67-df79-0f1a-dd64-8b6840d371c7@linaro.org> Date: Thu, 19 Oct 2017 11:07:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18/10/2017 21:32, Benjamin Gaignard wrote: > 2017-10-18 20:31 GMT+02:00 Thomas Gleixner : >> On Wed, 18 Oct 2017, Benjamin Gaignard wrote: >> >>> Convert driver to use timer_of helpers. This allow to remove >>> custom proprietary structure. >>> >>> Increase min delta value because if it is too small it could >>> generate too much interrupts and the system will not be able >>> to catch them all. >> >> This does two completely independent changes at once. What the heck has >> increasing min delta to do with converting it to timer_of() helpers? >> >> Nothing at all. So please split this into two distinct patches. Each doing >> ONE thing. > > I will do that. With push ups. -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog