From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1358BEB8FB7 for ; Wed, 6 Sep 2023 11:49:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240147AbjIFLt0 (ORCPT ); Wed, 6 Sep 2023 07:49:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37726 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229745AbjIFLtZ (ORCPT ); Wed, 6 Sep 2023 07:49:25 -0400 Received: from mailgw01.mediatek.com (unknown [60.244.123.138]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2512BCF; Wed, 6 Sep 2023 04:49:22 -0700 (PDT) X-UUID: 686ac61a4cab11eea33bb35ae8d461a2-20230906 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:CC:To:Subject:MIME-Version:Date:Message-ID; bh=52E412ODifuzDOHdYgLGCZhv8rQa4JIlCqlA9ZnKBJs=; b=IZYVBI9Shkjttp75FFilqlGWq9G/NCDCH23vuNjYxKGZ2xFyYzDeQxH/b2fJnlom+eFA1ilCEAqrhbIYQx7chUrPqXWUcr/hMnWXA+bSqIEzMwFwakzyXWXokaHUrqnQZmX38TcaTkGX2aJZSgYt4JMTLX0ol2psBn+JdXTzAU8=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.31,REQID:73db00ef-4cc4-4ab3-a951-fa7f2e73f5c9,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:0ad78a4,CLOUDID:9a13b7c2-1e57-4345-9d31-31ad9818b39f,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0,EDM:-3,IP:nil,U RL:0,File:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO, DKR:0,DKP:0,BRR:0,BRE:0 X-CID-BVR: 0,NGT X-CID-BAS: 0,NGT,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR X-UUID: 686ac61a4cab11eea33bb35ae8d461a2-20230906 Received: from mtkmbs13n1.mediatek.inc [(172.21.101.193)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 380854610; Wed, 06 Sep 2023 19:49:16 +0800 Received: from mtkmbs11n1.mediatek.inc (172.21.101.186) by MTKMBS14N2.mediatek.inc (172.21.101.76) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Wed, 6 Sep 2023 19:49:15 +0800 Received: from [172.21.84.99] (172.21.84.99) by mtkmbs11n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.1118.26 via Frontend Transport; Wed, 6 Sep 2023 19:49:14 +0800 Message-ID: <10cbb316-b08b-a8c1-87dd-00e6ad2aeb7a@mediatek.com> Date: Wed, 6 Sep 2023 19:49:11 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v2 2/2] arm64: dts: mediatek: add device-tree for Genio 1200 EVK board Content-Language: en-US To: Krzysztof Kozlowski , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Frank Wunderlich , =?UTF-8?Q?Bernhard_Rosenkr=c3=a4nzer?= , Sean Wang , , , , CC: Bear Wang , Pablo Sun , Macpaul Lin , Ben Lok References: <20230904092043.5157-1-macpaul.lin@mediatek.com> <20230906092527.18281-1-macpaul.lin@mediatek.com> <20230906092527.18281-2-macpaul.lin@mediatek.com> <2cb8069a-976b-0af4-a427-1e63ba4e7870@linaro.org> <951e34bc-dda3-f9d4-b251-7f0fd02052ee@mediatek.com> <145f9a3e-af61-c62f-1752-2abb7663d7a3@linaro.org> From: Macpaul Lin In-Reply-To: <145f9a3e-af61-c62f-1752-2abb7663d7a3@linaro.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/6/23 18:20, Krzysztof Kozlowski wrote: > > > External email : Please do not click links or open attachments until you > have verified the sender or the content. > > On 06/09/2023 12:15, Macpaul Lin wrote: >>>> + >>>> +wifi_3v3: wifi-3v3-regulator { >>> >>> This is a friendly reminder during the review process. >>> >>> It seems my previous comments were not fully addressed. Maybe my >>> feedback got lost between the quotes, maybe you just forgot to apply it. >>> Please go back to the previous discussion and either implement all >>> requested changes or keep discussing them. >> >> >> This keeps a format with -regulator is because I've found some other use >> cases. It seems "-regulator" or "regulator-" could be arbitrary. I'm not >> sure if it is a new guideline for regulator's node. If there is in the >> devicetree document, maybe I just missed it? > > What is the point to name in the same DTS some of the regulators > "regulator-foo" and some "foo-regulator"? > > Best regards, > Krzysztof > It looks like I've miss the point of previous review comment. Updated new patch in v3 series. Thanks Macpaul Lin