From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A3BFC54EBE for ; Mon, 9 Jan 2023 14:03:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237284AbjAIODW (ORCPT ); Mon, 9 Jan 2023 09:03:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40160 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237153AbjAIODA (ORCPT ); Mon, 9 Jan 2023 09:03:00 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED5472A2; Mon, 9 Jan 2023 06:01:50 -0800 (PST) Received: from [192.168.1.15] (91-154-32-225.elisa-laajakaista.fi [91.154.32.225]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 0506A6CF; Mon, 9 Jan 2023 15:01:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1673272908; bh=Da0e2+6JV7BXvqC1k2nu/Yn2oEiFT2mbWd4tL+IOTEw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=LCNS06L8T7yYRtE1Y1OVET6PaoWohWAXgmbeqypT9Z9LuyRxD6lRg56cg9wcxV13X GglIR0BAkn44+16ATtppVwjws1nelI6APtc5abvLUAElej/D8K355juJgOfWL1g+TI o+HGT2tiwy6/7rzVusUh+bEERjehQHyAfGb7TnZw= Message-ID: <10d369c1-4aaf-f59d-dbdc-48f04424a030@ideasonboard.com> Date: Mon, 9 Jan 2023 16:01:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v6 7/8] media: i2c: add DS90UB913 driver Content-Language: en-US To: Andy Shevchenko Cc: Laurent Pinchart , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Wolfram Sang , Luca Ceresoli , Matti Vaittinen , Mauro Carvalho Chehab , Peter Rosin , Liam Girdwood , Mark Brown , Sakari Ailus , Michael Tretter , Shawn Tu , Hans Verkuil , Mike Pagano , =?UTF-8?Q?Krzysztof_Ha=c5=82asa?= , Marek Vasut References: <20230105140307.272052-1-tomi.valkeinen@ideasonboard.com> <20230105140307.272052-8-tomi.valkeinen@ideasonboard.com> <5173a16a-83c5-5cfe-f6ce-03e1c90e8790@ideasonboard.com> From: Tomi Valkeinen In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/01/2023 15:58, Andy Shevchenko wrote: > On Mon, Jan 09, 2023 at 03:55:39PM +0200, Andy Shevchenko wrote: >> On Mon, Jan 09, 2023 at 02:59:01PM +0200, Tomi Valkeinen wrote: >>> On 09/01/2023 13:07, Andy Shevchenko wrote: >>>> On Sun, Jan 08, 2023 at 06:06:34AM +0200, Laurent Pinchart wrote: >>>>> On Thu, Jan 05, 2023 at 04:03:06PM +0200, Tomi Valkeinen wrote: > > ... > >>>>>> + gc->of_node = priv->client->dev.of_node; >>>> >>>> We don't have of_node anymore in gc. And if the parent device is set, you can >>>> drop this line (it will work with older and newer kernels. Otherwise, use >>>> fwnode. >>> >>> What do you mean "we don't have of_node anymore"? > > Just to add that you missed "gc" in the quote which is crucial to get > what I meant. Well, the original text was just above... >> There is no of_node member of struct gpio_chip anymore. This will fail >> to compile. It's in Linus' tree, but yes, now that I fetched linux-next I see it's gone. Tomi