From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D066C433EF for ; Mon, 4 Apr 2022 13:36:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354517AbiDDNiq (ORCPT ); Mon, 4 Apr 2022 09:38:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52542 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353940AbiDDNin (ORCPT ); Mon, 4 Apr 2022 09:38:43 -0400 Received: from mail-il1-x134.google.com (mail-il1-x134.google.com [IPv6:2607:f8b0:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3325C3BFA8 for ; Mon, 4 Apr 2022 06:36:47 -0700 (PDT) Received: by mail-il1-x134.google.com with SMTP id e9so6850756ilu.9 for ; Mon, 04 Apr 2022 06:36:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ieee.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=v7AXDrNkV0E+GuzQu0vkT521m8L2g3R8JZyBRpFSWSw=; b=UGi9dsHRnoLPuvzo1S1EvzOOZUHvSHzXBsnw16StvvXGSTaLht7DkGhbmNgritgWoy 3S+vdPPYNI+CbTwzNjbbeE7Hw32snvtBgdJ3quDnbJxCb0KtnPvvUi8IKemKBU7+NTcn YDKZMZsFTdUZ44CkNQLumu4g37ihuSwyQIWPc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=v7AXDrNkV0E+GuzQu0vkT521m8L2g3R8JZyBRpFSWSw=; b=loRt0yYl2Xn+drgGt92Fg14M7kUoC73Ce5IjaJMk9cfflCLzj+4Y2EL2lpJykZH/Wy t9xrUpaZG/3tLlODaSrzDWp3mcZBbTwXM9dgpiCWxlkTr2COhBTkmbW8e4lYweO5LG6v K28mbSFqvobuvZWJl3/w5lyvDIblrdf9FoAuTcqsE0OEy4/cAF+Mozg6PsSXx1ooW5n+ 1fzfhKWoW9yMvEAj7sNv0TC7DzhXlt5jXl4bt9YaMWwl3EtvNXT5pJjUFm8wAE2yAwts mibzy9UhLa4FMXkDm3zqQ30vJVdoeZdh6Jb0EOZWNz1u3MG6QOkMVohU2yjJ5mn7bZq/ z/aA== X-Gm-Message-State: AOAM533OBk7/sPur5aMBys3m4MSMKEpUeghlFpqIkRzoV8hU6VKraGNM o/Rw3GmqtGwzkJPr0P7x5IiipQ== X-Google-Smtp-Source: ABdhPJxKWPVlUvcgfx4SvYr7vos8yA4v2Mi7qUIHb9E64q6XZsCGDyBE3n+kdaQg4cAx6UmNyhWkjw== X-Received: by 2002:a05:6e02:178d:b0:2ca:1ad2:c471 with SMTP id y13-20020a056e02178d00b002ca1ad2c471mr5284025ilu.311.1649079406491; Mon, 04 Apr 2022 06:36:46 -0700 (PDT) Received: from [172.22.22.4] (c-73-185-129-58.hsd1.mn.comcast.net. [73.185.129.58]) by smtp.googlemail.com with ESMTPSA id x8-20020a92d648000000b002ca2dc1a74esm3188537ilp.58.2022.04.04.06.36.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 Apr 2022 06:36:46 -0700 (PDT) Message-ID: <10d4f538-249d-f78c-b90f-298c9727d58d@ieee.org> Date: Mon, 4 Apr 2022 08:36:44 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 2/2] dt-bindings: net: qcom,ipa: finish the qcom,smp2p example Content-Language: en-US To: Krzysztof Kozlowski , Manivannan Sadhasivam , Andy Gross , Bjorn Andersson , Jassi Brar , Rob Herring , Krzysztof Kozlowski , "David S. Miller" , Jakub Kicinski , Paolo Abeni , Alex Elder , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, netdev@vger.kernel.org Cc: Rob Herring References: <20220402155551.16509-1-krzysztof.kozlowski@linaro.org> <20220402155551.16509-2-krzysztof.kozlowski@linaro.org> From: Alex Elder In-Reply-To: <20220402155551.16509-2-krzysztof.kozlowski@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/2/22 10:55 AM, Krzysztof Kozlowski wrote: > The example using qcom,smp2p should have all necessary properties, to > avoid DT schema validation warnings. Looks good to me. The particular values don't match any reality, but that doesn't matter for getting the syntactic parse to pass without error or warning. Thanks. Reviewed-by: Alex Elder > > Reported-by: Rob Herring > Signed-off-by: Krzysztof Kozlowski > --- > Documentation/devicetree/bindings/net/qcom,ipa.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/qcom,ipa.yaml b/Documentation/devicetree/bindings/net/qcom,ipa.yaml > index 58ecc62adfaa..dd4bb2e74880 100644 > --- a/Documentation/devicetree/bindings/net/qcom,ipa.yaml > +++ b/Documentation/devicetree/bindings/net/qcom,ipa.yaml > @@ -182,6 +182,12 @@ examples: > > smp2p-mpss { > compatible = "qcom,smp2p"; > + interrupts = ; > + mboxes = <&apss_shared 6>; > + qcom,smem = <94>, <432>; > + qcom,local-pid = <0>; > + qcom,remote-pid = <5>; > + > ipa_smp2p_out: ipa-ap-to-modem { > qcom,entry-name = "ipa"; > #qcom,smem-state-cells = <1>; > @@ -193,6 +199,7 @@ examples: > #interrupt-cells = <2>; > }; > }; > + > ipa@1e40000 { > compatible = "qcom,sdm845-ipa"; >