From: Yongxing Mou <quic_yongmou@quicinc.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Rob Clark <robdclark@gmail.com>,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Sean Paul <sean@poorly.run>,
Marijn Suijten <marijn.suijten@somainline.org>,
David Airlie <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Kuogee Hsieh <quic_khsieh@quicinc.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: <linux-arm-msm@vger.kernel.org>,
<dri-devel@lists.freedesktop.org>,
<freedreno@lists.freedesktop.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/4] dt-bindings: display/msm: Redocument the dp-controller for QCS8300
Date: Wed, 12 Feb 2025 19:13:32 +0800 [thread overview]
Message-ID: <10d83c88-9f72-4577-95ba-bb1fd1ef36d1@quicinc.com> (raw)
In-Reply-To: <531a23fe-940a-4e9a-b023-5f1789ac65a5@kernel.org>
On 2025/2/12 16:35, Krzysztof Kozlowski wrote:
> On 12/02/2025 08:12, Yongxing Mou wrote:
>> We need to enable mst for qcs8300, dp0 controller will support 2 streams
>> output. So not reuse sm8650 dp controller driver and will add a new driver
>> patch for qcs8300 mst feature. Modify the corresponding dt-bingding file
>> to compatible with the qcs8300-dp.
>>
>> Signed-off-by: Yongxing Mou <quic_yongmou@quicinc.com>
> NAK. You just said qcs8300 is compatible with sm8650. I did not ask
> about drivers, I asked about hardware.
>
> This is messy approach. Describe properly the hardware first, instead of
> sending two conflicting patchsets.
>
> Best regards,
> Krzysztof
Hi, Krzysztof, thanks for reviewing, i want to explain why i submitted
this patch. Patch
https://lore.kernel.org/all/20250114-dts_qcs8300-v3-1-d114cc5e4af9@quicinc.com/
and
https://lore.kernel.org/all/20250120-mdssdt_qcs8300-v4-2-1687e7842125@quicinc.com/
is the qcs8300 display enablement changes. It base on current linux base
code and it only support SST mode, so in the SST mode, qcs8300 dp
controller driver is quite same with sm8650, struct msm_dp_desc only
have 3 members(io_start, id and wide_bus_supported) and they are same
both in qcs8300 and sm8650, so we reuse it. BTW, for dp phy hardware
version, qcs8300 and sm8650 is different.
For this patch series,
https://lore.kernel.org/all/20250212-mst_qcs8300-v1-0-38a8aa08394b@quicinc.com/
, it is made on top of
https://lore.kernel.org/all/20241205-dp_mst-v1-0-f8618d42a99a@quicinc.com/
which is a new feature for msm platform and not fully reviewed all the
code. Currently patch series enable the MST feature for qcs8300, so the
dp controller need to support stream 1, and we need add max_streams and
intf_map in the struct msm_dp_desc to support MST. So we don't reuse the
sm8650 drivers in this patch series.
For my understanding, qcs8300 SST changes should merge
first(https://lore.kernel.org/all/20250114-dts_qcs8300-v3-0-d114cc5e4af9@quicinc.com/
and
https://lore.kernel.org/all/20250120-mdssdt_qcs8300-v4-0-1687e7842125@quicinc.com/),
and next is the MST base commits
(https://lore.kernel.org/all/20241205-dp_mst-v1-0-f8618d42a99a@quicinc.com/),
and this patch series should merge at last. why i post qcs8300
enablement changes first and then post the MST changes instead of post
them together? Because our dependency, i mean this patch series
(https://lore.kernel.org/all/20241205-dp_mst-v1-0-f8618d42a99a@quicinc.com/),
it has about 45 changes, so it might take lots of time to merge. we just
want to make sure that display can work on DP SST mode first.
So I am just understand that the previous commit was not an incorrect
commit, but rather two functionalities were changed in the same place.
Thanks,
Yongxing
next prev parent reply other threads:[~2025-02-12 11:13 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-12 7:12 [PATCH 0/4] Add MST support for qcs8300 platform Yongxing Mou
2025-02-12 7:12 ` [PATCH 1/4] dt-bindings: display/msm: Redocument the dp-controller for QCS8300 Yongxing Mou
2025-02-12 8:35 ` Krzysztof Kozlowski
2025-02-12 11:13 ` Yongxing Mou [this message]
2025-02-12 11:28 ` Krzysztof Kozlowski
2025-02-12 13:44 ` Konrad Dybcio
2025-02-19 9:43 ` Yongxing Mou
2025-02-12 10:41 ` Dmitry Baryshkov
2025-02-12 10:53 ` Krzysztof Kozlowski
2025-02-12 12:26 ` Dmitry Baryshkov
2025-02-19 9:56 ` Yongxing Mou
2025-02-19 12:56 ` Dmitry Baryshkov
2025-02-12 10:42 ` Dmitry Baryshkov
2025-02-19 9:57 ` Yongxing Mou
2025-02-12 7:12 ` [PATCH 2/4] dt-bindings: display/msm: Add stream 1 pixel clock " Yongxing Mou
2025-02-12 8:34 ` Krzysztof Kozlowski
2025-02-19 10:00 ` Yongxing Mou
2025-02-12 7:12 ` [PATCH 3/4] drm/msm/dp: Populate the max_streams for qcs8300 mst controller Yongxing Mou
2025-02-12 7:12 ` [PATCH 4/4] arm64: dts: qcom: qcs8300: Add support for stream 1 clk for DP MST Yongxing Mou
2025-02-12 23:41 ` Konrad Dybcio
2025-02-19 10:00 ` Yongxing Mou
2025-02-12 9:06 ` [PATCH 0/4] Add MST support for qcs8300 platform Krzysztof Kozlowski
2025-02-19 10:02 ` Yongxing Mou
2025-02-19 10:58 ` Dmitry Baryshkov
2025-02-19 12:07 ` Krzysztof Kozlowski
2025-02-20 7:33 ` Yongxing Mou
2025-02-12 10:51 ` Dmitry Baryshkov
2025-02-19 10:07 ` Yongxing Mou
2025-02-12 14:35 ` Rob Herring
2025-02-12 14:54 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10d83c88-9f72-4577-95ba-bb1fd1ef36d1@quicinc.com \
--to=quic_yongmou@quicinc.com \
--cc=airlied@gmail.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=marijn.suijten@somainline.org \
--cc=mripard@kernel.org \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_khsieh@quicinc.com \
--cc=robdclark@gmail.com \
--cc=robh@kernel.org \
--cc=sean@poorly.run \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®