From: Mark Brown <broonie@kernel.org>
To: Svyatoslav Ryhel <clamor95@gmail.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Thierry Reding <thierry.reding@kernel.org>,
Jonathan Hunter <jonathanh@nvidia.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/2] ASoC: tegra: Support WM8994 by machine driver
Date: Tue, 13 Oct 2026 19:52:04 +0100 [thread overview]
Message-ID: <10dca96b-78b2-4f46-bf4f-de67d25c916e@sirena.org.uk> (raw)
In-Reply-To: <20261013183226.513658-3-clamor95@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 856 bytes --]
On Tue, Oct 13, 2026 at 09:32:26PM +0300, Svyatoslav Ryhel wrote:
> Add Wolfson Microelectronics WM8994 codec support to the Tegra ASoC
> machine driver. The WM8994 codec is found on devices like LG Optimus 2X
> (P990/star) and Samsung Captivate Glide (SGH-i927).
> +// SPDX-License-Identifier: GPL-2.0-only
> +/*
> + * tegra_wm8994.c - Tegra machine ASoC driver for boards using WM8994 codec.
Please make the entire comment a C++ one so things look more
intentional.
> +static const struct snd_kcontrol_new tegra_wm8994_controls[] = {
> + SOC_DAPM_PIN_SWITCH("Int Spk"),
> + SOC_DAPM_PIN_SWITCH("Internal Mic 1"),
> + SOC_DAPM_PIN_SWITCH("Internal Mic 2"),
> + SOC_DAPM_PIN_SWITCH("Mic Jack"),
> + SOC_DAPM_PIN_SWITCH("Line Out"),
> + SOC_DAPM_PIN_SWITCH("FM Radio"),
> +};
There's no Line Out or FM Radio widgets, you should get errors during
probe.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-10-13 18:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-13 18:32 [PATCH v1 0/2] " Svyatoslav Ryhel
2026-10-13 18:32 ` [PATCH v1 1/2] ASoC: dt-bindings: nvidia,tegra-audio: document WM8994 CODEC Svyatoslav Ryhel
2026-10-13 18:32 ` [PATCH v1 2/2] ASoC: tegra: Support WM8994 by machine driver Svyatoslav Ryhel
2026-10-13 18:52 ` Mark Brown [this message]
2026-10-13 18:56 ` Svyatoslav Ryhel
2026-10-13 19:04 ` Mark Brown
2026-10-14 9:00 ` Svyatoslav Ryhel
2026-10-14 11:49 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10dca96b-78b2-4f46-bf4f-de67d25c916e@sirena.org.uk \
--to=broonie@kernel.org \
--cc=clamor95@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=perex@perex.cz \
--cc=robh@kernel.org \
--cc=thierry.reding@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®